Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: Source/bindings/templates/union.cpp

Issue 700323003: Use Web IDL Union types in Service Worker's Cache interface (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix union conversion fallback template logic Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/modules/v8/generated.gypi ('k') | Source/bindings/tests/results/core/UnionTypesCore.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/union.cpp
diff --git a/Source/bindings/templates/union.cpp b/Source/bindings/templates/union.cpp
index 9e0bccec36263174f2d35c4a878d9ef435329219..0d02b061cc3a6db1d4efc730ef2164ce602e7dc5 100644
--- a/Source/bindings/templates/union.cpp
+++ b/Source/bindings/templates/union.cpp
@@ -131,9 +131,10 @@ void V8{{container.cpp_class}}::toImpl(v8::Isolate* isolate, v8::Handle<v8::Valu
return;
}
- {% endif %}
+ {% else %}
{# 19. TypeError #}
exceptionState.throwTypeError("Not a valid union member.");
haraken 2014/11/07 00:06:36 I guess we unconditionally need exceptionState.thr
bashi 2014/11/07 00:24:07 When I implement this, I thought we need to make t
haraken 2014/11/07 01:15:33 Makes sense, thanks!
+ {% endif %}
}
v8::Handle<v8::Value> toV8({{container.cpp_class}}& impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
« no previous file with comments | « Source/bindings/modules/v8/generated.gypi ('k') | Source/bindings/tests/results/core/UnionTypesCore.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698