Issue 700313002: Improve consistency of nextNodeWithGreaterTabIndex() and previousNodeWithLowerTabIndex().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 700313002: Improve consistency of nextNodeWithGreaterTabIndex() and previousNodeWithLowerTabIndex(). (Closed)

Created:
6 years, 1 month ago by tkent

Modified:
6 years, 1 month ago

Reviewers:
hayato, kochi

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Improve consistency of nextNodeWithGreaterTabIndex() and previousNodeWithLowerTabIndex(). * nextNodeWithGreaterTabIndex: Set |currentTabIndex| to |winningTabIndex| They are same in the |if| block. However |currentTabIndex| looks better. * previousNodeWithLowerTabIndex: Remove isNonKeyboardFocusableShadowHost() check. It's redandunt because shouldVisit() contains it. BUG= TEST=none; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184889