Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: src/d8-debug.h

Issue 7003113: corrected parts in d8 that accesses the new "deisolated" Thread in platform.h (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/d8.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 i::Isolate* isolate_; 92 i::Isolate* isolate_;
93 93
94 friend class ReceiverThread; 94 friend class ReceiverThread;
95 }; 95 };
96 96
97 97
98 // Thread reading from debugged V8 instance. 98 // Thread reading from debugged V8 instance.
99 class ReceiverThread: public i::Thread { 99 class ReceiverThread: public i::Thread {
100 public: 100 public:
101 ReceiverThread(i::Isolate* isolate, RemoteDebugger* remote_debugger) 101 ReceiverThread(i::Isolate* isolate, RemoteDebugger* remote_debugger)
102 : Thread(isolate, "d8:ReceiverThrd"), 102 : Thread("d8:ReceiverThrd"),
fschneider 2011/06/10 12:19:51 It seems the isolate parameter is not used anymore
103 remote_debugger_(remote_debugger) {} 103 remote_debugger_(remote_debugger) {}
104 ~ReceiverThread() {} 104 ~ReceiverThread() {}
105 105
106 void Run(); 106 void Run();
107 107
108 private: 108 private:
109 RemoteDebugger* remote_debugger_; 109 RemoteDebugger* remote_debugger_;
110 }; 110 };
111 111
112 112
113 // Thread reading keyboard input. 113 // Thread reading keyboard input.
114 class KeyboardThread: public i::Thread { 114 class KeyboardThread: public i::Thread {
115 public: 115 public:
116 explicit KeyboardThread(i::Isolate* isolate, RemoteDebugger* remote_debugger) 116 explicit KeyboardThread(i::Isolate* isolate, RemoteDebugger* remote_debugger)
117 : Thread(isolate, "d8:KeyboardThrd"), 117 : Thread("d8:KeyboardThrd"),
118 remote_debugger_(remote_debugger) {} 118 remote_debugger_(remote_debugger) {}
119 ~KeyboardThread() {} 119 ~KeyboardThread() {}
120 120
121 void Run(); 121 void Run();
122 122
123 private: 123 private:
124 RemoteDebugger* remote_debugger_; 124 RemoteDebugger* remote_debugger_;
125 }; 125 };
126 126
127 127
(...skipping 21 matching lines...) Expand all
149 RemoteDebuggerEvent* next_; 149 RemoteDebuggerEvent* next_;
150 150
151 friend class RemoteDebugger; 151 friend class RemoteDebugger;
152 }; 152 };
153 153
154 154
155 } // namespace v8 155 } // namespace v8
156 156
157 157
158 #endif // V8_D8_DEBUG_H_ 158 #endif // V8_D8_DEBUG_H_
OLDNEW
« no previous file with comments | « src/d8.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698