Issue 7003113: corrected parts in d8 that accesses the new "deisolated" Thread in platform.h

Issue 7003113: corrected parts in d8 that accesses the new "deisolated" Thread in platform.h (Closed)

Created:
9 years, 6 months ago by Yang

Modified:
9 years, 6 months ago

Reviewers:
fschneider, mnaganov (inactive)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

corrected parts in d8 that accesses the new "deisolated" Thread in platform.h BUG= d8 wouldn't compile with the new platform.h and the new constructor of the Thread class TEST=

Patch Set 2 : removed isolates from throughout d8 #

Total comments: 2

Patch Set 3 : my bad, presubmit caught something #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -14 lines)			Patch
M	src/d8.cc	View	1	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/d8-debug.h	View	1 2	4 chunks	+6 lines, -7 lines	0 comments	Download
M	src/d8-debug.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yang

Hi Mikhail, your last changes on the Thread class in src/platform.h resulted in making d8 ...

9 years, 6 months ago (2011-06-10 11:29:24 UTC) #1

fschneider

http://codereview.chromium.org/7003113/diff/1/src/d8-debug.h File src/d8-debug.h (right): http://codereview.chromium.org/7003113/diff/1/src/d8-debug.h#newcode102 src/d8-debug.h:102: : Thread("d8:ReceiverThrd"), It seems the isolate parameter is not ...

9 years, 6 months ago (2011-06-10 12:19:51 UTC) #2

Yang

Removed unnecessary usage of isolates in d8 as suggested. http://codereview.chromium.org/7003113/diff/2003/src/d8.cc File src/d8.cc (right): http://codereview.chromium.org/7003113/diff/2003/src/d8.cc#newcode631 src/d8.cc:631: ...

9 years, 6 months ago (2011-06-10 12:36:16 UTC) #4

mnaganov (inactive)

9 years, 6 months ago (2011-06-10 12:40:42 UTC) #5

On 2011/06/10 12:36:16, yangguo wrote:
> Removed unnecessary usage of isolates in d8 as suggested.
> 
> http://codereview.chromium.org/7003113/diff/2003/src/d8.cc
> File src/d8.cc (right):
> 
> http://codereview.chromium.org/7003113/diff/2003/src/d8.cc#newcode631
> src/d8.cc:631: i::Debug* debug = i::Isolate::Current()->debug();
> still need the current isolate to get the debugger object though.
> 
> http://codereview.chromium.org/7003113/diff/2003/src/d8.cc#newcode654
> src/d8.cc:654: i::Debug* debug = i::Isolate::Current()->debug();
> ditto

Thank you, LGTM.

Expand Messages | Collapse Messages