"Deiceolate" Thread classes.

src/platform-openbsd.cc

 // Copyright 2006-2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 378 matching lines @@
               kMmapFd, kMmapFdOffset) != MAP_FAILED;
 }
 
 
 class Thread::PlatformData : public Malloced {
  public:
   pthread_t thread_;  // Thread handle for pthread.
 };
 
 
 Thread::Thread(Isolate* isolate, const Options& options)

[Vitaly Repeshko, 2011/06/10 08:18:50]

Won't compile.

[mnaganov (inactive), 2011/06/10 09:31:32]

Thanks! Somehow, I have missed this file.

     : data_(new PlatformData),
       isolate_(isolate),
       stack_size_(options.stack_size) {
   set_name(options.name);
 }
 
 
 Thread::Thread(Isolate* isolate, const char* name)

[Vitaly Repeshko, 2011/06/10 08:18:50]

Ditto.

[mnaganov (inactive), 2011/06/10 09:31:32]

Done.

     : data_(new PlatformData),
       isolate_(isolate),
       stack_size_(0) {
   set_name(name);
 }
 
 
 Thread::~Thread() {
   delete data_;
 }
 
 
 static void* ThreadEntry(void* arg) {
   Thread* thread = reinterpret_cast<Thread*>(arg);
   // This is also initialized by the first argument to pthread_create() but we
   // don't know which thread will run first (the original thread or the new
   // one) so we initialize it here too.
   thread->data()->thread_ = pthread_self();
   ASSERT(thread->data()->thread_ != kNoThread);
   Thread::SetThreadLocal(Isolate::isolate_key(), thread->isolate());

[Vitaly Repeshko, 2011/06/10 08:18:50]

Remove this line.

[mnaganov (inactive), 2011/06/10 09:31:32]

Done.

   thread->Run();
   return NULL;
 }
 
 
 void Thread::set_name(const char* name) {
   strncpy(name_, name, sizeof(name_));
   name_[sizeof(name_) - 1] = '\0';
 }
 
@@ skipping 216 matching lines @@
 
 
 class SignalSender : public Thread {
  public:
   enum SleepInterval {
     HALF_INTERVAL,
     FULL_INTERVAL
   };
 
   explicit SignalSender(int interval)
-      : Thread(NULL, "SignalSender"),
+      : Thread("SignalSender"),
         interval_(interval) {}
 
   static void AddActiveSampler(Sampler* sampler) {
     ScopedLock lock(mutex_);
     SamplerRegistry::AddActiveSampler(sampler);
     if (instance_ == NULL) {
       // Install a signal handler.
       struct sigaction sa;
       sa.sa_sigaction = ProfilerSignalHandler;
       sigemptyset(&sa.sa_mask);
@@ skipping 143 matching lines @@
 
 void Sampler::Stop() {
   ASSERT(IsActive());
   SignalSender::RemoveActiveSampler(this);
   SetActive(false);
 }
 
 #endif  // ENABLE_LOGGING_AND_PROFILING
 
 } }  // namespace v8::internal