Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: chrome/browser/extensions/extension_special_storage_policy.cc

Issue 7003098: Start refractoring extension permissions into ExtensionPermissionSet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: See if rebasing fixes the tests... Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_special_storage_policy.cc
diff --git a/chrome/browser/extensions/extension_special_storage_policy.cc b/chrome/browser/extensions/extension_special_storage_policy.cc
index fd3ccc4c7090c78569309debb4c272faf231c613..9c95c1c266b01d295ea290b09cbd8fff83e6b997 100644
--- a/chrome/browser/extensions/extension_special_storage_policy.cc
+++ b/chrome/browser/extensions/extension_special_storage_policy.cc
@@ -34,16 +34,18 @@ void ExtensionSpecialStoragePolicy::GrantRightsForExtension(
const Extension* extension) {
DCHECK(extension);
if (!extension->is_hosted_app() &&
- !extension->HasApiPermission(Extension::kUnlimitedStoragePermission) &&
- !extension->HasApiPermission(Extension::kFileBrowserHandlerPermission)) {
+ !extension->HasAPIPermission(
+ ExtensionAPIPermission::kUnlimitedStorage) &&
+ !extension->HasAPIPermission(
+ ExtensionAPIPermission::kFileBrowserHandler)) {
return;
}
base::AutoLock locker(lock_);
if (extension->is_hosted_app())
protected_apps_.Add(extension);
- if (extension->HasApiPermission(Extension::kUnlimitedStoragePermission))
+ if (extension->HasAPIPermission(ExtensionAPIPermission::kUnlimitedStorage))
unlimited_extensions_.Add(extension);
- if (extension->HasApiPermission(Extension::kFileBrowserHandlerPermission))
+ if (extension->HasAPIPermission(ExtensionAPIPermission::kFileBrowserHandler))
file_handler_extensions_.Add(extension);
}
@@ -51,16 +53,18 @@ void ExtensionSpecialStoragePolicy::RevokeRightsForExtension(
const Extension* extension) {
DCHECK(extension);
if (!extension->is_hosted_app() &&
- !extension->HasApiPermission(Extension::kUnlimitedStoragePermission) &&
- !extension->HasApiPermission(Extension::kFileBrowserHandlerPermission)) {
+ !extension->HasAPIPermission(
+ ExtensionAPIPermission::kUnlimitedStorage) &&
+ !extension->HasAPIPermission(
+ ExtensionAPIPermission::kFileBrowserHandler)) {
return;
}
base::AutoLock locker(lock_);
if (extension->is_hosted_app())
protected_apps_.Remove(extension);
- if (extension->HasApiPermission(Extension::kUnlimitedStoragePermission))
+ if (extension->HasAPIPermission(ExtensionAPIPermission::kUnlimitedStorage))
unlimited_extensions_.Remove(extension);
- if (extension->HasApiPermission(Extension::kFileBrowserHandlerPermission))
+ if (extension->HasAPIPermission(ExtensionAPIPermission::kFileBrowserHandler))
file_handler_extensions_.Remove(extension);
}
« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/extension_tabs_module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698