Issue 7003083: Don't allocate handles for substrings when filling up the split result array.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7003083: Don't allocate handles for substrings when filling up the split result array.

Created:
9 years, 6 months ago by sandholm

Modified:
9 years, 6 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Don't allocate handles for substrings when filling up the split result array.

Patch Set 2 : '' #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -25 lines)			Patch
	M	src/runtime.cc	View	1	4 chunks	+42 lines, -25 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/7003083/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7003083/diff/1/src/runtime.cc#newcode5811 src/runtime.cc:5811: part_start, This is an unpretty combination of handle ...

9 years, 6 months ago (2011-06-10 07:32:17 UTC) #2

sandholm

9 years, 6 months ago (2011-06-10 10:13:31 UTC) #3

http://codereview.chromium.org/7003083/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/7003083/diff/1/src/runtime.cc#newcode5811
src/runtime.cc:5811: part_start,
On 2011/06/10 07:32:17, Lasse Reichstein wrote:
> This is an unpretty combination of handle and non-handle code.
> Make the JSArray and FixedArray allocations not use handles either, and remove
> the HandleScope.
> 
> Perhaps don't allocate the JSArray until the end.

Done.

Expand Messages | Collapse Messages

Issue 7003083: Don't allocate handles for substrings when filling up the split result array.

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages