Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 700283002: Remove 1d glyph positions from nvpr text (Closed)

Created:
6 years, 1 month ago by Chris Dalton
Modified:
6 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org, Kimmo Kinnunen, Mark Kilgard
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove 1d glyph positions from nvpr text Removes the case for x-only glyph positions from nvpr text, opting to always send 2d glyph positions instead. The 1d glyph positions saved a bit on memory bandwidth, but ended up a net loss because they required more updates to the view matrix. Now we can draw an entire paragraph without touching the GL state, whereas before we would have to update the view matrix at every new line. BUG=skia: Committed: https://skia.googlesource.com/skia/+/38e13adc18555f8e75f5ae6762e7c307214ae37f

Patch Set 1 #

Patch Set 2 : Formatting #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -67 lines) Patch
M src/gpu/GrStencilAndCoverTextContext.h View 2 chunks +1 line, -5 lines 1 comment Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 1 8 chunks +19 lines, -62 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Chris Dalton
https://codereview.chromium.org/700283002/diff/20001/src/gpu/GrStencilAndCoverTextContext.h File src/gpu/GrStencilAndCoverTextContext.h (left): https://codereview.chromium.org/700283002/diff/20001/src/gpu/GrStencilAndCoverTextContext.h#oldcode81 src/gpu/GrStencilAndCoverTextContext.h:81: void initGlyphs(SkGlyphCache* cache); This declaration was accidentally left in ...
6 years, 1 month ago (2014-11-05 22:12:03 UTC) #2
bsalomon
lgtm
6 years, 1 month ago (2014-11-06 15:56:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700283002/20001
6 years, 1 month ago (2014-11-06 17:30:42 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 14:02:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 38e13adc18555f8e75f5ae6762e7c307214ae37f

Powered by Google App Engine
This is Rietveld 408576698