Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: src/assembler_ia32.h

Issue 700263003: Rearrange emit vs emitIAS. Wait till function is done before dumping text. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: remove comment... might end up using the iterator Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/assembler.cpp ('k') | tests_lit/llvm2ice_tests/64bit.pnacl.ll » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/assembler_ia32.h
diff --git a/src/assembler_ia32.h b/src/assembler_ia32.h
index 77159c49303e943f2fa65008f0ed1698dcca16ff..a7ffc9e1ec539ec748f6ba6c3874fa95afe47f7b 100644
--- a/src/assembler_ia32.h
+++ b/src/assembler_ia32.h
@@ -364,7 +364,7 @@ class AssemblerX86 : public Assembler {
AssemblerX86 &operator=(const AssemblerX86 &) = delete;
public:
- explicit AssemblerX86(bool use_far_branches = false) : buffer_(*this) {
+ explicit AssemblerX86(bool use_far_branches = false) : Assembler() {
// This mode is only needed and implemented for MIPS and ARM.
assert(!use_far_branches);
(void)use_far_branches;
@@ -829,15 +829,6 @@ public:
buffer_.FinalizeInstructions(region);
}
- // Expose the buffer, for bringup...
- intptr_t GetPosition() const { return buffer_.GetPosition(); }
- template <typename T> T LoadBuffer(intptr_t position) const {
- return buffer_.Load<T>(position);
- }
- AssemblerFixup *GetLatestFixup(intptr_t position) const {
- return buffer_.GetLatestFixup(position);
- }
-
private:
inline void EmitUint8(uint8_t value);
inline void EmitInt16(int16_t value);
@@ -868,8 +859,6 @@ private:
LabelVector LocalLabels;
Label *GetOrCreateLabel(SizeT Number, LabelVector &Labels);
-
- AssemblerBuffer buffer_;
};
inline void AssemblerX86::EmitUint8(uint8_t value) {
« no previous file with comments | « src/assembler.cpp ('k') | tests_lit/llvm2ice_tests/64bit.pnacl.ll » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698