Rearrange emit vs emitIAS. Wait till function is done before dumping text.

src/assembler.cpp

 //===- subzero/src/assembler.cpp - Assembler base class -------------------===//
 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // Modified by the Subzero authors.
 //
 //===----------------------------------------------------------------------===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file implements the Assembler class.
 //
 //===----------------------------------------------------------------------===//
 
 #include "assembler.h"
+#include "IceGlobalContext.h"
 #include "IceMemoryRegion.h"
+#include "IceOperand.h"
 
 namespace Ice {
 
 static uintptr_t NewContents(Assembler &assembler, intptr_t capacity) {
   uintptr_t result = assembler.AllocateBytes(capacity);
   return result;
 }
 
 #ifndef NDEBUG
 AssemblerBuffer::EnsureCapacity::EnsureCapacity(AssemblerBuffer *buffer) {
@@ skipping 93 matching lines @@
 
   // Update the cursor and recompute the limit.
   cursor_ += delta;
   limit_ = ComputeLimit(new_contents, new_capacity);
 
   // Verify internal state.
   assert(Capacity() == new_capacity);
   assert(Size() == old_size);
 }
 
+void Assembler::emitIASBytes(GlobalContext *Ctx) const {
+  Ostream &Str = Ctx->getStrEmit();
+  intptr_t EndPosition = buffer_.Size();
+  intptr_t StartPosition = 0;
+  const intptr_t FixupSize = 4;
+  while (StartPosition < EndPosition) {
+    AssemblerFixup *LastFixup = buffer_.GetLatestFixup(StartPosition);

[Jim Stichnoth, 2014/11/06 00:02:13]

The total work done in all the calls to GetLatestFixup() will be O(N^2) in the
number of fixups.  Can you maybe change the loop structure to loop forward over
the fixups, and emit the non-fixup bytes in between?

[jvoung (off chromium), 2014/11/06 00:47:13]

Ah right, I wasn't looking at how GetLatestFixup() is done too closely. Changed
to iterate over fixups and splat bytes as it iterates.

+    intptr_t LastFixupLoc = LastFixup ? LastFixup->position() : EndPosition;
+    for (intptr_t i = StartPosition; i < LastFixupLoc; ++i) {
+      Str << "\t.byte 0x";
+      Str.write_hex(buffer_.Load<uint8_t>(i));
+      Str << "\n";
+    }
+    if (LastFixup) {
+      Str << "\t.long ";
+      const ConstantRelocatable *Reloc = LastFixup->value();
+      bool IsPCRel = LastFixup->kind() == FK_PcRel_4;
+      if (Reloc->getSuppressMangling())
+        Str << Reloc->getName();
+      else
+        Str << Ctx->mangleName(Reloc->getName());
+      if (Reloc->getOffset()) {
+        Str << " + " << Reloc->getOffset();
+      }
+      if (IsPCRel)
+        Str << " - (. + " << FixupSize << ")";
+      Str << "\n";
+      LastFixupLoc += FixupSize;
+      assert(LastFixupLoc <= EndPosition);
+    }
+    // Continue another round, after the latest fixup.
+    StartPosition = LastFixupLoc;
+  }
+}
+
 } // end of namespace Ice