Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 700213005: Teach sky_server how to use more threads and not drop requests (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Teach sky_server how to use more threads and not drop requests This is lame, but seems to fix the timeout problem http://stackoverflow.com/questions/2685089/cherrypy-and-concurrency Committed: https://chromium.googlesource.com/external/mojo/+/413f4a9721c64eec4c94338660e43c04a20fb4ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M sky/tools/sky_server View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
eseidel
sad panda
6 years, 1 month ago (2014-11-05 23:24:23 UTC) #2
abarth-chromium
lgtm
6 years, 1 month ago (2014-11-05 23:24:57 UTC) #3
esprehn
This doesn't seem right, does cherrypy not have a request queue?
6 years, 1 month ago (2014-11-05 23:25:23 UTC) #5
eseidel
Committed patchset #1 (id:1) manually as 413f4a9721c64eec4c94338660e43c04a20fb4ee (presubmit successful).
6 years, 1 month ago (2014-11-05 23:25:39 UTC) #6
eseidel
6 years, 1 month ago (2014-11-05 23:27:22 UTC) #7
Message was sent while issue was closed.
It does.

cherrypy.server.socket_queue_size defaults to 5 I'm told.

We're just flooding it.  

https://github.com/pivotal/jasmine-py/issues/2

Powered by Google App Engine
This is Rietveld 408576698