Issue 700183002: A few Windows GN build fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 700183002: A few Windows GN build fixes. (Closed)

Created:
6 years, 1 month ago by jam

Modified:
6 years, 1 month ago

Reviewers:
scottmg

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	build/secondary/third_party/nss/BUILD.gn	View		3 chunks	+7 lines, -2 lines	0 comments	Download
	M	net/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/494329e721bed7e2397664cf2859ed5889ef0c83 Cr-Commit-Position: refs/heads/master@{#302844}

6 years, 1 month ago (2014-11-05 19:09:56 UTC) #4

jam

6 years, 1 month ago (2014-11-05 19:10:03 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
494329e721bed7e2397664cf2859ed5889ef0c83 (presubmit successful).