Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 700143004: C++11: Use type aliases instead of typedefs (Closed)

Created:
6 years, 1 month ago by Mark Mentovai
Modified:
6 years, 1 month ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

C++11: Use type aliases instead of typedefs. This replaces all occurrences of “typedef Y X;” with “using X = Y;”. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/de0979b930f798df2b9e86abb303f18275ec3e62

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -113 lines) Patch
M client/capture_context_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M client/simple_string_dictionary.h View 1 chunk +1 line, -1 line 0 comments Download
M client/simple_string_dictionary.cc View 1 chunk +1 line, -1 line 0 comments Download
M client/simple_string_dictionary_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M client/simulate_crash_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M compat/mac/mach-o/getsect.h View 1 chunk +4 lines, -4 lines 0 comments Download
M compat/mac/mach-o/getsect.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M minidump/minidump_string_writer.h View 2 chunks +6 lines, -6 lines 0 comments Download
M minidump/minidump_thread_writer_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M minidump/test/minidump_writable_test_util.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M snapshot/cpu_context.h View 3 chunks +5 lines, -5 lines 0 comments Download
M snapshot/mac/mach_o_image_reader_test.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M snapshot/mac/mach_o_image_symbol_table_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/mac/process_reader_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/mac/process_types.h View 3 chunks +14 lines, -14 lines 0 comments Download
M snapshot/mac/process_types.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M snapshot/mac/process_types/traits.h View 1 chunk +7 lines, -7 lines 0 comments Download
M util/file/fd_io.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M util/mach/exc_server_variants.cc View 17 chunks +18 lines, -18 lines 0 comments Download
M util/mach/exc_server_variants_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M util/mach/exception_ports.h View 2 chunks +2 lines, -2 lines 0 comments Download
M util/mach/symbolic_constants_mach_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M util/misc/initialization_state_dcheck.h View 1 chunk +1 line, -1 line 0 comments Download
M util/misc/symbolic_constants_common.h View 2 chunks +2 lines, -2 lines 0 comments Download
M util/stdlib/string_number_conversion.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M util/test/posix/close_multiple.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 1 month ago (2014-11-05 18:58:49 UTC) #2
Robert Sesek
LGTM
6 years, 1 month ago (2014-11-05 19:05:32 UTC) #3
Mark Mentovai
6 years, 1 month ago (2014-11-05 19:09:13 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
de0979b930f798df2b9e86abb303f18275ec3e62 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698