Issue 700093002: IDL: Support nullable union types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 700093002: IDL: Support nullable union types (Closed)

Created:
6 years, 1 month ago by Jens Widell

Modified:
6 years, 1 month ago

Reviewers:

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

IDL: Support nullable union types Two part fix: 1) Make idl_type.is_implicit_nullable true for union types, indicating that the generated union type containers can represent null. 2) When using IdlType.name as a C++ name, as we do for union types, make sure to "look through" a possible IdlNullableType wrapper, since the "OrNull" suffix it adds makes no sense in C++ code. BUG=240176

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -4 lines)			Patch
M	Source/bindings/scripts/compute_interfaces_info_individual.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/scripts/idl_types.py	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/bindings/scripts/v8_types.py	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	Source/bindings/tests/idls/core/TestObject.idl	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/bindings/tests/results/core/V8TestObject.cpp	View	2 chunks	+34 lines, -0 lines	0 comments	Download