Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 700043002: Export TrialExists to Java layer (Closed)

Created:
6 years, 1 month ago by Jaekyun Seok (inactive)
Modified:
6 years, 1 month ago
Reviewers:
Ted C, nyquist, Maria
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Export TrialExists to Java layer This change exports TrialExists to Java layer which is used in https://chrome-internal-review.googlesource.com/#/c/182195/ to check whether a trial actually exists or not. BUG=412156 Committed: https://crrev.com/6528ae016085d197f502f99f5c6b4b8d8be6bb9b Cr-Commit-Position: refs/heads/master@{#302773}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M base/android/field_trial_list.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M base/android/java/src/org/chromium/base/FieldTrialList.java View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Jaekyun Seok (inactive)
Please review this change to export TrialExists to Java layer which is used in https://chrome-internal-review.googlesource.com/#/c/182195/ ...
6 years, 1 month ago (2014-11-05 01:18:34 UTC) #2
Maria
lgtm
6 years, 1 month ago (2014-11-05 01:26:31 UTC) #3
Ted C
lgtm
6 years, 1 month ago (2014-11-05 02:02:34 UTC) #4
nyquist
lgtm, but could you expand a little bit in the commit description? Many people do ...
6 years, 1 month ago (2014-11-05 06:02:36 UTC) #5
Jaekyun Seok (inactive)
On 2014/11/05 06:02:36, nyquist wrote: > lgtm, but could you expand a little bit in ...
6 years, 1 month ago (2014-11-05 08:13:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700043002/1
6 years, 1 month ago (2014-11-05 08:14:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-05 10:13:38 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 10:14:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6528ae016085d197f502f99f5c6b4b8d8be6bb9b
Cr-Commit-Position: refs/heads/master@{#302773}

Powered by Google App Engine
This is Rietveld 408576698