Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 70003004: Reland "Implement Math.sin, cos and tan using table lookup and spline interpolation." (Closed)

Created:
7 years, 1 month ago by Yang
Modified:
7 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Reland "Implement Math.sin, cos and tan using table lookup and spline interpolation." This relands r17594 with necessary fixes. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=17654

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -229 lines) Patch
M src/arm/full-codegen-arm.cc View 1 1 chunk +0 lines, -36 lines 0 comments Download
M src/hydrogen.cc View 1 5 chunks +6 lines, -37 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 1 chunk +0 lines, -36 lines 0 comments Download
M src/math.js View 1 5 chunks +93 lines, -3 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 2 chunks +7 lines, -36 lines 0 comments Download
M src/objects.h View 4 chunks +7 lines, -3 lines 0 comments Download
M src/objects.cc View 2 chunks +10 lines, -14 lines 0 comments Download
M src/objects-inl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/runtime.h View 3 chunks +2 lines, -3 lines 0 comments Download
M src/runtime.cc View 2 chunks +43 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 1 chunk +0 lines, -36 lines 0 comments Download
M test/mjsunit/constant-folding-2.js View 1 1 chunk +0 lines, -24 lines 0 comments Download
M test/mjsunit/sin-cos.js View 1 1 chunk +94 lines, -1 line 0 comments Download
M test/mozilla/mozilla.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/test262/test262.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
Second attempt at fixing and relanding. As usual, the second patch set is the diff ...
7 years, 1 month ago (2013-11-12 12:25:29 UTC) #1
Jakob Kummerow
LGTM
7 years, 1 month ago (2013-11-12 13:01:36 UTC) #2
Yang
7 years, 1 month ago (2013-11-12 14:43:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r17654 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698