Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/combobutton.js

Issue 700023002: Show generic file handler more modestly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed nits. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/file_manager/file_manager/foreground/js/file_tasks.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/file_manager/foreground/js/ui/combobutton.js
diff --git a/ui/file_manager/file_manager/foreground/js/ui/combobutton.js b/ui/file_manager/file_manager/foreground/js/ui/combobutton.js
index e6a84b4b4aaae2f26ae4d374d0074856ca260ad7..b87d69ac185307eb47da6f019b5ad45a12371453 100644
--- a/ui/file_manager/file_manager/foreground/js/ui/combobutton.js
+++ b/ui/file_manager/file_manager/foreground/js/ui/combobutton.js
@@ -62,13 +62,18 @@ cr.define('cr.ui', function() {
this.actionNode_.textContent = defaultItem.label || '';
if (defaultItem.iconType) {
+ this.actionNode_.classList.add('with-icon');
this.actionNode_.style.backgroundImage = '';
this.actionNode_.setAttribute('file-type-icon', defaultItem.iconType);
} else if (defaultItem.iconUrl) {
+ this.actionNode_.classList.add('with-icon');
this.actionNode_.style.backgroundImage =
'url(' + defaultItem.iconUrl + ')';
+ this.actionNode_.removeAttribute('file-type-icon');
} else {
+ this.actionNode_.classList.remove('with-icon');
this.actionNode_.style.backgroundImage = '';
+ this.actionNode_.removeAttribute('file-type-icon');
}
},
« no previous file with comments | « ui/file_manager/file_manager/foreground/js/file_tasks.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698