Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: src/spaces.cc

Issue 7000023: Do inline object filtering (via page flags) before call to RecordWriteStub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/gc
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/spaces.cc
diff --git a/src/spaces.cc b/src/spaces.cc
index 29206e310b3b0a5d6ec16e3e8c1e1511322d12d8..8fdee1136896ee091e1dccd7ab214f9a01556a8a 100644
--- a/src/spaces.cc
+++ b/src/spaces.cc
@@ -398,6 +398,7 @@ NewSpacePage* NewSpacePage::Initialize(Heap* heap, Address start) {
NOT_EXECUTABLE,
heap->new_space());
chunk->initialize_scan_on_scavenge(true);
+ heap->incremental_marking()->SetNewSpacePageFlags(chunk);
return static_cast<NewSpacePage*>(chunk);
}
@@ -417,7 +418,6 @@ MemoryChunk* MemoryChunk::Initialize(Heap* heap,
chunk->set_owner(owner);
chunk->markbits()->Clear();
chunk->initialize_scan_on_scavenge(false);
- ASSERT(OFFSET_OF(MemoryChunk, scan_on_scavenge_) == kScanOnScavengeOffset);
ASSERT(OFFSET_OF(MemoryChunk, flags_) == kFlagsOffset);
if (executable == EXECUTABLE) chunk->SetFlag(IS_EXECUTABLE);
@@ -930,6 +930,10 @@ void NewSpace::Flip() {
SemiSpace tmp = from_space_;
from_space_ = to_space_;
to_space_ = tmp;
+
+ NewSpacePage* old_active_page = from_space_.current_page();
+ NewSpacePage* new_active_page = to_space_.current_page();
+ new_active_page->CopyFlagsFrom(old_active_page);
}

Powered by Google App Engine
This is Rietveld 408576698