Do inline object filtering (via page flags) before call to RecordWriteStub.

src/ia32/macro-assembler-ia32.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 14 matching lines @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #include "v8.h"
 
 #if defined(V8_TARGET_ARCH_IA32)
 
 #include "bootstrapper.h"
 #include "codegen.h"
 #include "debug.h"
+#include "macro-assembler-ia32-inl.h"
 #include "runtime.h"
 #include "serialize.h"
 
 namespace v8 {
 namespace internal {
 
 // -------------------------------------------------------------------------
 // MacroAssembler implementation.
 
 MacroAssembler::MacroAssembler(Isolate* arg_isolate, void* buffer, int size)
@@ skipping 164 matching lines @@
   ASSERT(!object.is(address));
   ASSERT(!value.is(address));
   if (emit_debug_code()) {
     AbortIfSmi(object);
   }
 
   if (emit_remembered_set == OMIT_REMEMBERED_SET &&
       FLAG_incremental_marking == false) {
     return;
   }
+
+  if (FLAG_debug_code) {
+    NearLabel ok;
+    cmp(value, Operand(address, 0));
+    j(equal, &ok);
+    Abort("Registers did not match in write barrier");
+    bind(&ok);
+  }
+
   // First, check if a write barrier is even needed. The tests below
   // catch stores of Smis and stores into young gen.
   NearLabel done;
 
   if (smi_check == INLINE_SMI_CHECK) {
     // Skip barrier if writing a smi.
     ASSERT_EQ(0, kSmiTag);
     test(value, Immediate(kSmiTagMask));
     j(zero, &done);
   }
 
+  CheckPageFlag(value,
+                value,

[Erik Corry, 2011/05/11 18:53:57]

Add comment that value is used as scratch here.

[Vyacheslav Egorov (Chromium), 2011/05/13 11:06:52]

Done.

+                MemoryChunk::CONTAINS_INTERESTING_VALUES,
+                zero,
+                &done);
+  CheckPageFlag(object,
+                value,
+                MemoryChunk::CONTAINS_INTERESTING_DESTINATIONS,
+                zero,
+                &done);
+
   RecordWriteStub stub(object, value, address, emit_remembered_set, fp_mode);
   CallStub(&stub);
 
-  if (smi_check == INLINE_SMI_CHECK) {
-    bind(&done);
-  }
+  bind(&done);
 
   // Clobber clobbered registers when running with the debug-code flag
   // turned on to provoke errors.
   if (emit_debug_code()) {
     mov(address, Immediate(BitCast<int32_t>(kZapValue)));
     mov(value, Immediate(BitCast<int32_t>(kZapValue)));
   }
 }
 
 
@@ skipping 1891 matching lines @@
 
   // Check that the code was patched as expected.
   ASSERT(masm_.pc_ == address_ + size_);
   ASSERT(masm_.reloc_info_writer.pos() == address_ + size_ + Assembler::kGap);
 }
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_IA32