Source/core/html/track/WebVTTParser.cpp - Issue 69993003: Split VTTCue from TextTrackCue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/WebVTTParser.cpp

Issue 69993003: Split VTTCue from TextTrackCue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/track/WebVTTParser.cpp

diff --git a/Source/core/html/track/WebVTTParser.cpp b/Source/core/html/track/WebVTTParser.cpp

index b3f0632def09785ca527886cc6e981a44ed51bf9..f5c53b9145510ab83308cc1b0ce334629c2e81dc 100644

--- a/Source/core/html/track/WebVTTParser.cpp

+++ b/Source/core/html/track/WebVTTParser.cpp

@@ -120,7 +120,7 @@ WebVTTParser::WebVTTParser(WebVTTParserClient* client, Document& document)

{

}

-void WebVTTParser::getNewCues(Vector<RefPtr<TextTrackCue> >& outputCues)

+void WebVTTParser::getNewCues(Vector<RefPtr<VTTCue> >& outputCues)

{

outputCues = m_cuelist;

m_cuelist.clear();

@@ -375,7 +375,7 @@ void WebVTTParser::createNewCue()

if (!m_currentContent.length())

return;

- RefPtr<TextTrackCue> cue = TextTrackCue::create(*m_document, m_currentStartTime, m_currentEndTime, m_currentContent.toString());

+ RefPtr<VTTCue> cue = VTTCue::create(*m_document, m_currentStartTime, m_currentEndTime, m_currentContent.toString());

cue->setId(m_currentId);

cue->setCueSettings(m_currentSettings);