Issue 699893005: Specs: Give DocumentFragment and Document a common ancestor that is

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 699893005: Specs: Give DocumentFragment and Document a common ancestor that is (Closed)

Created:
6 years, 1 month ago by Hixie

Modified:
6 years, 1 month ago

Reviewers:

CC:
mojo-reviews_chromium.org, ojan, abarth-chromium

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Specs: Give DocumentFragment and Document a common ancestor that is not also a common ancestor of Element, so that they can all have findId(); use this to make the complexity of QuerySelector more accurate Committed: https://chromium.googlesource.com/external/mojo/+/c048b7f8a247c52992b43ca88517a1fcb21b02e5

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -6 lines)			Patch
	M	sky/specs/apis.md	View		2 chunks	+10 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Hixie

Committed patchset #1 (id:1) manually as c048b7f8a247c52992b43ca88517a1fcb21b02e5.

6 years, 1 month ago (2014-11-05 00:24:23 UTC) #1

esprehn

6 years, 1 month ago (2014-11-05 00:55:49 UTC) #2

Message was sent while issue was closed.

On 2014/11/05 00:24:23, Hixie wrote:
> Committed patchset #1 (id:1) manually as
> c048b7f8a247c52992b43ca88517a1fcb21b02e5.

Is there a reason for wanting findId on fragments? Historically we didn't
support this, why not make them a TreeScope of you want this?

Expand Messages | Collapse Messages