Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 699873005: Add shared_library build rule for Go on Mojo. (Closed)

Created:
6 years, 1 month ago by gautham
Modified:
6 years, 1 month ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add shared_library build rule for Go on Mojo. Committed: https://crrev.com/fa3a3cc37f07130dedf6a017bbca6903d9ef4f7c Cr-Commit-Position: refs/heads/master@{#302652}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M build/go/rules.gni View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
gautham
6 years, 1 month ago (2014-11-04 19:18:58 UTC) #2
gautham
I had missed adding this rule in the previous CL.
6 years, 1 month ago (2014-11-04 19:19:21 UTC) #3
jamesr
lgtm
6 years, 1 month ago (2014-11-04 19:20:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699873005/1
6 years, 1 month ago (2014-11-04 19:22:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 20:15:55 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 20:16:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa3a3cc37f07130dedf6a017bbca6903d9ef4f7c
Cr-Commit-Position: refs/heads/master@{#302652}

Powered by Google App Engine
This is Rietveld 408576698