Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 699873002: DevTools: [SSP] refactoring to remove styleRule.section property (Closed)

Created:
6 years, 1 month ago by lushnikov
Modified:
6 years, 1 month ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: [SSP] refactoring to remove styleRule.section property The patch is a first step towards cleaning up StylesSidebarPane and introduction of structured object instead of styleRule objects. This patch removes styleRule.section property, and kills unneeded section.uniqueProperties list. R=vsevik, pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184875

Patch Set 1 #

Patch Set 2 : fix syntax #

Total comments: 2

Patch Set 3 : addressed comments #

Patch Set 4 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -28 lines) Patch
M LayoutTests/http/tests/inspector/elements-test.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 1 2 3 12 chunks +33 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
lushnikov
Please, take a look
6 years, 1 month ago (2014-11-04 10:05:10 UTC) #1
lushnikov
FYI: This patch depends on https://codereview.chromium.org/697773004/
6 years, 1 month ago (2014-11-04 12:50:08 UTC) #2
vsevik
lgtm https://codereview.chromium.org/699873002/diff/20001/Source/devtools/front_end/elements/StylesSidebarPane.js File Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/699873002/diff/20001/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode138 Source/devtools/front_end/elements/StylesSidebarPane.js:138: WebInspector.StylesSidebarPane._affectsNode = function(styleRule) Let's name it _hasMatchingSelectors
6 years, 1 month ago (2014-11-05 08:04:50 UTC) #3
lushnikov
https://codereview.chromium.org/699873002/diff/20001/Source/devtools/front_end/elements/StylesSidebarPane.js File Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/699873002/diff/20001/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode138 Source/devtools/front_end/elements/StylesSidebarPane.js:138: WebInspector.StylesSidebarPane._affectsNode = function(styleRule) On 2014/11/05 08:04:50, vsevik wrote: > ...
6 years, 1 month ago (2014-11-05 11:02:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699873002/60001
6 years, 1 month ago (2014-11-05 13:55:16 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 15:29:27 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as 184875

Powered by Google App Engine
This is Rietveld 408576698