content/common/bluetooth/bluetooth_error.h - Issue 699843003: bluetooth: Impl uses new WebBluetoothDevice in content/browser.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/bluetooth/bluetooth_error.h

Issue 699843003: bluetooth: Impl uses new WebBluetoothDevice in content/browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/child/bluetooth/bluetooth_dispatcher.h ('K') | « content/common/bluetooth/OWNERS ('k') | content/common/bluetooth/bluetooth_messages.h » ('j') | content/common/bluetooth/bluetooth_messages.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_COMMON_BLUETOOTH_BLUETOOTH_ERROR_H_

	6 #define CONTENT_COMMON_BLUETOOTH_BLUETOOTH_ERROR_H_

	7

	8 namespace content {

	9

	10 enum class BluetoothError { NOT_FOUND, SECURITY, ENUM_MAX_VALUE = SECURITY };
	Jeffrey Yasskin 2014/11/24 23:30:11 These probably deserve a comment that they will pr These probably deserve a comment that they will produce a DOMException in the renderer named NotFoundError, SecurityError, etc. Is there any need to pass the 'message' string back with the error name? scheib 2014/11/25 16:11:06 Done. Show quoted text On 2014/11/24 23:30:11, Jeffrey Yasskin wrote: > These probably deserve a comment that they will produce a DOMException in the > renderer named NotFoundError, SecurityError, etc. Done. Show quoted text > Is there any need to pass the 'message' string back with the error name? Currently, no messages are needed. Later the implementation will likely have useful strings to send to developers. Then I plan to add variations to these enumerations, but only associate with the string in the child process. The exception will be if a procedural generated message is warranted, and I'll expand the IPC message at that time if needed.
	11

	12 } // namespace content

	13

	14 #endif // CONTENT_COMMON_BLUETOOTH_BLUETOOTH_ERROR_H_

OLD	NEW