bluetooth: Impl uses new WebBluetoothDevice in content/browser.

content/browser/bluetooth/bluetooth_dispatcher_host.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/bluetooth/bluetooth_dispatcher_host.h"
+
+#include "content/common/bluetooth/bluetooth_messages.h"
+
+namespace content {
+
+BluetoothDispatcherHost::BluetoothDispatcherHost()
+    : BrowserMessageFilter(BluetoothMsgStart),
+      bluetoothMockDataSet_(MockData::NOT_MOCKING),
+      bluetoothRequestDeviceRejectType_(BluetoothError::NOT_FOUND) {
+}
+
+bool BluetoothDispatcherHost::OnMessageReceived(const IPC::Message& message) {
+  bool handled = true;
+  IPC_BEGIN_MESSAGE_MAP(BluetoothDispatcherHost, message)
+  IPC_MESSAGE_HANDLER(BluetoothHostMsg_RequestDevice, OnRequestDevice)
+  IPC_MESSAGE_HANDLER(BluetoothHostMsg_SetBluetoothMockDataSetForTesting,
+                      OnSetBluetoothMockDataSetForTesting)
+  IPC_MESSAGE_UNHANDLED(handled = false)
+  IPC_END_MESSAGE_MAP()
+  return handled;
+}
+
+BluetoothDispatcherHost::~BluetoothDispatcherHost() {
+}
+
+void BluetoothDispatcherHost::OnRequestDevice(int thread_id, int request_id) {
+  // Mock implementation util a more complete implementation is built out.
+  switch (bluetoothMockDataSet_) {
+    case MockData::NOT_MOCKING: {
+      Send(new BluetoothMsg_RequestDeviceError(thread_id, request_id,
+                                               BluetoothError::NOT_FOUND));
+      return;

[nasko, 2014/11/25 00:57:23]

No need to return here, just plain break would work. This will allow you to drop
the {} for each case statement.

[Jeffrey Yasskin, 2014/11/25 01:08:07]

Using return here, and the NOTREACHED after the switch, allows Vince to take
advantage of the -Wswitch check that he's listed all possible values of the
enum. default: would turn off that checking. 'course it's up to the code owner
whether you want that check.

The braces are optional either way.

[scheib, 2014/11/25 16:11:06]

Yes, as Jeffrey said, I prefer compile failure when enumerations are added so
that all uses are examined and handled.

[nasko, 2014/11/25 23:27:01]

Heh, I learn something new every day. Thanks for the details!

+    }
+    case MockData::REJECT: {
+      Send(new BluetoothMsg_RequestDeviceError(
+          thread_id, request_id, bluetoothRequestDeviceRejectType_));
+      return;
+    }
+    case MockData::RESOLVE: {
+      Send(new BluetoothMsg_RequestDeviceSuccess(thread_id, request_id,
+                                                 "Empty Mock deviceId"));
+      return;
+    }
+  }
+  NOTREACHED();

[nasko, 2014/11/25 00:57:23]

This belongs in a default switch statement.

[scheib, 2014/11/25 16:11:05]

Intended, see above re compile checking all enum cases.

+}
+
+void BluetoothDispatcherHost::OnSetBluetoothMockDataSetForTesting(
+    const std::string& name) {
+  if (name == "RejectRequestDevice_NotFoundError") {
+    bluetoothMockDataSet_ = MockData::REJECT;
+    bluetoothRequestDeviceRejectType_ = BluetoothError::NOT_FOUND;
+  } else if (name == "RejectRequestDevice_SecurityError") {
+    bluetoothMockDataSet_ = MockData::REJECT;
+    bluetoothRequestDeviceRejectType_ = BluetoothError::SECURITY;
+  } else if (name == "ResolveRequestDevice_Empty" ||  // TODO Remove.

[Jeffrey Yasskin, 2014/11/24 23:30:11]

TODOs generally have a '(username):' after them:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#TODO_Comments

[scheib, 2014/11/25 16:11:05]

Done.

+             name == "Single Empty Device") {
+    bluetoothMockDataSet_ = MockData::RESOLVE;
+  } else {
+    bluetoothMockDataSet_ = MockData::NOT_MOCKING;
+  }
+}
+
+}  // namespace content