Disable three BatteryStatusServiceTests on Windows.

Disable three BatteryStatusServiceTests on Windows.

BatteryStatusServiceTest.AddCallbackAfterUpdate
BatteryStatusServiceTest.RemoveOneCallback
BatteryStatusServiceTest.TwoCallbacksUpdate

These tests fail on DrMemory bots and locally on Windows.

NOTRY=true
TBR=timvolodine
BUG=429942
Committed: https://crrev.com/4d54576d6bc28518e853791c8b1a05813f72cb50
Cr-Commit-Position: refs/heads/master@{#302559}

[benwells, 2014-11-04 02:47:58]

benwells@chromium.org changed reviewers:
+ timvolodine@chromium.org

[benwells, 2014-11-04 02:48:14]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2014-11-04 02:49:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/699823002/1

[commit-bot: I haz the power, 2014-11-04 02:51:29]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-04 02:52:25]

Patchset 1 (id:??) landed as
https://crrev.com/4d54576d6bc28518e853791c8b1a05813f72cb50
Cr-Commit-Position: refs/heads/master@{#302559}

[chromium-reviews, 2014-11-04 05:22:24]

+ppi FYI

On Tue, Nov 4, 2014 at 2:48 AM, <benwells@chromium.org> wrote:

> Reviewers: timvolodine,
>
> Description:
> Disable three BatteryStatusServiceTests on Windows.
>
> BatteryStatusServiceTest.AddCallbackAfterUpdate
> BatteryStatusServiceTest.RemoveOneCallback
> BatteryStatusServiceTest.TwoCallbacksUpdate
>
> These tests fail on DrMemory bots and locally on Windows.
>
> NOTRY=true
> TBR=timvolodine
> BUG=429942
>
> Please review this at https://codereview.chromium.org/699823002/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+21, -3 lines):
>   M device/battery/battery_status_service_unittest.cc
>
>
> Index: device/battery/battery_status_service_unittest.cc
> diff --git a/device/battery/battery_status_service_unittest.cc
> b/device/battery/battery_status_service_unittest.cc
> index f286c9fc9efbc5dd425fb03418cc975a3b64f90f..
> d249d570ef1c6ad4c53652c5b2a70770bba708f0 100644
> --- a/device/battery/battery_status_service_unittest.cc
> +++ b/device/battery/battery_status_service_unittest.cc
> @@ -139,7 +139,13 @@ TEST_F(BatteryStatusServiceTest, AddFirstCallback) {
>    EXPECT_EQ(1, battery_manager()->stop_invoked_count());
>  }
>
> -TEST_F(BatteryStatusServiceTest, AddCallbackAfterUpdate) {
> +// Fails on Windows. http://crbug.com/429942.
> +#if defined(OS_WIN)
> +#define MAYBE_AddCallbackAfterUpdate DISABLED_AddCallbackAfterUpdate
> +#else
> +#define MAYBE_AddCallbackAfterUpdate AddCallbackAfterUpdate
> +#endif
> +TEST_F(BatteryStatusServiceTest, MAYBE_AddCallbackAfterUpdate) {
>    scoped_ptr<BatterySubscription> subscription1 =
> AddCallback(callback1());
>    BatteryStatus status;
>    battery_manager()->InvokeUpdateCallback(status);
> @@ -152,7 +158,13 @@ TEST_F(BatteryStatusServiceTest,
> AddCallbackAfterUpdate) {
>    EXPECT_EQ(1, callback2_invoked_count());
>  }
>
> -TEST_F(BatteryStatusServiceTest, TwoCallbacksUpdate) {
> +// Fails on Windows. http://crbug.com/429942.
> +#if defined(OS_WIN)
> +#define MAYBE_TwoCallbacksUpdate DISABLED_TwoCallbacksUpdate
> +#else
> +#define MAYBE_TwoCallbacksUpdate TwoCallbacksUpdate
> +#endif
> +TEST_F(BatteryStatusServiceTest, MAYBE_TwoCallbacksUpdate) {
>    scoped_ptr<BatterySubscription> subscription1 =
> AddCallback(callback1());
>    scoped_ptr<BatterySubscription> subscription2 =
> AddCallback(callback2());
>
> @@ -172,7 +184,13 @@ TEST_F(BatteryStatusServiceTest, TwoCallbacksUpdate)
> {
>    EXPECT_EQ(status.level, battery_status().level);
>  }
>
> -TEST_F(BatteryStatusServiceTest, RemoveOneCallback) {
> +// Fails on Windows. http://crbug.com/429942.
> +#if defined(OS_WIN)
> +#define MAYBE_RemoveOneCallback DISABLED_RemoveOneCallback
> +#else
> +#define MAYBE_RemoveOneCallback RemoveOneCallback
> +#endif
> +TEST_F(BatteryStatusServiceTest, MAYBE_RemoveOneCallback) {
>    scoped_ptr<BatterySubscription> subscription1 =
> AddCallback(callback1());
>    scoped_ptr<BatterySubscription> subscription2 =
> AddCallback(callback2());
>
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.