Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 699763002: Fix an issue that a browser seek is requested after decoder draining is interrupted. (Closed)

Created:
6 years, 1 month ago by qinmin
Modified:
6 years, 1 month ago
Reviewers:
wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix an issue that a browser seek is requested after decoder draining is interrupted. When decoder is draining, the current access unit is pointing to the config change AU. If something interrupts the draining, a surface change for example, CreateMediaCodecBridge() will fail because the current AU is not an i-frame. This will cause an unnecessary browser seek. To avoid this, we should call OnDecoderDrained() first to let video decoder know that config change AU is consumed. The issue is captured by the DecoderDrainInterruptedBySurfaceChange test on nexus 9. And this change reenables that test, so no additional test is added. BUG=429889 Committed: https://crrev.com/800e030e283ccc0301b8d980e0ae152b93cb3420 Cr-Commit-Position: refs/heads/master@{#302640}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M media/base/android/media_decoder_job.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M media/base/android/media_source_player_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
qinmin
PTAL
6 years, 1 month ago (2014-11-04 00:13:24 UTC) #2
wolenetz
lgtm
6 years, 1 month ago (2014-11-04 18:19:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699763002/1
6 years, 1 month ago (2014-11-04 18:39:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 19:30:12 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 19:30:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/800e030e283ccc0301b8d980e0ae152b93cb3420
Cr-Commit-Position: refs/heads/master@{#302640}

Powered by Google App Engine
This is Rietveld 408576698