Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 699733002: removing setVertexArraySource from drawtarget (Closed)

Created:
6 years, 1 month ago by joshua.litt
Modified:
6 years, 1 month ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

removing setVertexArraySource from drawtarget BUG=skia: Committed: https://skia.googlesource.com/skia/+/d1aa8ff8700cbc083c8c27b7368a8482e65cdb08

Patch Set 1 #

Total comments: 1

Patch Set 2 : more cleanup #

Patch Set 3 : a bit more cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -231 lines) Patch
M src/gpu/GrBufferAllocPool.h View 1 2 chunks +0 lines, -17 lines 0 comments Download
M src/gpu/GrBufferAllocPool.cpp View 1 2 chunks +0 lines, -29 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +17 lines, -20 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 4 chunks +0 lines, -27 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 5 chunks +0 lines, -27 lines 0 comments Download
M src/gpu/GrGpu.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 2 chunks +2 lines, -51 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 2 4 chunks +4 lines, -48 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
joshualitt
6 years, 1 month ago (2014-11-03 22:04:41 UTC) #2
bsalomon
https://codereview.chromium.org/699733002/diff/1/src/gpu/GrDrawTarget.h File src/gpu/GrDrawTarget.h (left): https://codereview.chromium.org/699733002/diff/1/src/gpu/GrDrawTarget.h#oldcode703 src/gpu/GrDrawTarget.h:703: kArray_GeometrySrcType, //<! src was set using set*SourceToArray Can we ...
6 years, 1 month ago (2014-11-03 22:14:16 UTC) #3
bsalomon
Also GrBufferAllocPool appendIndices and appendVertices?
6 years, 1 month ago (2014-11-03 22:15:45 UTC) #4
joshualitt
feedback incorporated
6 years, 1 month ago (2014-11-03 22:19:42 UTC) #5
bsalomon
lgtm
6 years, 1 month ago (2014-11-04 14:46:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699733002/20001
6 years, 1 month ago (2014-11-04 15:27:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/420)
6 years, 1 month ago (2014-11-04 15:28:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699733002/40001
6 years, 1 month ago (2014-11-04 15:40:07 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 15:47:59 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as d1aa8ff8700cbc083c8c27b7368a8482e65cdb08

Powered by Google App Engine
This is Rietveld 408576698