Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: Source/core/css/FontFace.idl

Issue 699713003: IDL: ArrayBuffer and ArrayBufferView support for union types (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/FontFace.idl
diff --git a/Source/core/css/FontFace.idl b/Source/core/css/FontFace.idl
index d83c666b895521d146ba440d5c6622e89552a0d3..0665df83390463004900baf9e26af78ad6ba0ec2 100644
--- a/Source/core/css/FontFace.idl
+++ b/Source/core/css/FontFace.idl
@@ -39,10 +39,8 @@ enum FontFaceLoadStatus {
[
ActiveDOMObject,
- // FIXME: should be union type http://crbug.com/240176
- Constructor(DOMString family, DOMString source, optional FontFaceDescriptors descriptors),
- Constructor(DOMString family, ArrayBuffer source, optional FontFaceDescriptors descriptors),
- Constructor(DOMString family, ArrayBufferView source, optional FontFaceDescriptors descriptors),
+ // FIXME: This should be (DOMString or BinaryData), where BinaryData is typedef of (ArrayBuffer or ArrayBufferView)
+ Constructor(DOMString family, (DOMString or ArrayBuffer or ArrayBufferView) source, optional FontFaceDescriptors descriptors),
ConstructorCallWith=ExecutionContext,
WillBeGarbageCollected,
] interface FontFace {
« Source/bindings/tests/results/core/UnionTypesCore.cpp ('K') | « Source/core/css/FontFace.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698