Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: Source/core/html/shadow/MediaControlElementTypes.h

Issue 699703002: Clean up virtual function in Source/html (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/forms/RadioInputType.h ('k') | Source/core/html/track/InbandTextTrack.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
3 * Copyright (C) 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2012 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 }; 100 };
101 101
102 // ---------------------------- 102 // ----------------------------
103 103
104 class MediaControlDivElement : public HTMLDivElement, public MediaControlElement { 104 class MediaControlDivElement : public HTMLDivElement, public MediaControlElement {
105 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MediaControlDivElement); 105 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MediaControlDivElement);
106 public: 106 public:
107 virtual void trace(Visitor*) override; 107 virtual void trace(Visitor*) override;
108 108
109 protected: 109 protected:
110 MediaControlDivElement(MediaControls&, MediaControlElementType);
111
112 private:
110 virtual bool isMediaControlElement() const override final { return true; } 113 virtual bool isMediaControlElement() const override final { return true; }
111 MediaControlDivElement(MediaControls&, MediaControlElementType);
112 }; 114 };
113 115
114 // ---------------------------- 116 // ----------------------------
115 117
116 class MediaControlInputElement : public HTMLInputElement, public MediaControlEle ment { 118 class MediaControlInputElement : public HTMLInputElement, public MediaControlEle ment {
117 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MediaControlInputElement); 119 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MediaControlInputElement);
118 public: 120 public:
119 virtual void trace(Visitor*) override; 121 virtual void trace(Visitor*) override;
120 122
121 protected: 123 protected:
122 virtual bool isMediaControlElement() const override final { return true; }
123 MediaControlInputElement(MediaControls&, MediaControlElementType); 124 MediaControlInputElement(MediaControls&, MediaControlElementType);
124 125
125 private: 126 private:
126 virtual void updateDisplayType() { } 127 virtual void updateDisplayType() { }
128 virtual bool isMediaControlElement() const override final { return true; }
127 virtual bool isMouseFocusable() const override; 129 virtual bool isMouseFocusable() const override;
128 }; 130 };
129 131
130 // ---------------------------- 132 // ----------------------------
131 133
132 class MediaControlTimeDisplayElement : public MediaControlDivElement { 134 class MediaControlTimeDisplayElement : public MediaControlDivElement {
133 public: 135 public:
134 void setCurrentValue(double); 136 void setCurrentValue(double);
135 double currentValue() const { return m_currentValue; } 137 double currentValue() const { return m_currentValue; }
136 138
137 protected: 139 protected:
138 MediaControlTimeDisplayElement(MediaControls&, MediaControlElementType); 140 MediaControlTimeDisplayElement(MediaControls&, MediaControlElementType);
139 141
140 private: 142 private:
141 double m_currentValue; 143 double m_currentValue;
142 }; 144 };
143 145
144 } // namespace blink 146 } // namespace blink
145 147
146 #endif // MediaControlElementTypes_h 148 #endif // MediaControlElementTypes_h
OLDNEW
« no previous file with comments | « Source/core/html/forms/RadioInputType.h ('k') | Source/core/html/track/InbandTextTrack.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698