Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: Source/core/html/canvas/WebGLTexture.h

Issue 699703002: Clean up virtual function in Source/html (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLUnknownElement.h ('k') | Source/core/html/forms/RadioInputType.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 static bool isNPOT(GLsizei, GLsizei); 69 static bool isNPOT(GLsizei, GLsizei);
70 70
71 bool isNPOT() const; 71 bool isNPOT() const;
72 // Determine if texture sampling should always return [0, 0, 0, 1] (OpenGL E S 2.0 Sec 3.8.2). 72 // Determine if texture sampling should always return [0, 0, 0, 1] (OpenGL E S 2.0 Sec 3.8.2).
73 bool needToUseBlackTexture(TextureExtensionFlag) const; 73 bool needToUseBlackTexture(TextureExtensionFlag) const;
74 74
75 bool hasEverBeenBound() const { return object() && m_target; } 75 bool hasEverBeenBound() const { return object() && m_target; }
76 76
77 static GLint computeLevelCount(GLsizei width, GLsizei height); 77 static GLint computeLevelCount(GLsizei width, GLsizei height);
78 78
79 protected: 79 private:
80 explicit WebGLTexture(WebGLRenderingContextBase*); 80 explicit WebGLTexture(WebGLRenderingContextBase*);
81 81
82 virtual void deleteObjectImpl(blink::WebGraphicsContext3D*, Platform3DObject ) override; 82 virtual void deleteObjectImpl(blink::WebGraphicsContext3D*, Platform3DObject ) override;
83 83
84 private:
85 class LevelInfo { 84 class LevelInfo {
86 public: 85 public:
87 LevelInfo() 86 LevelInfo()
88 : valid(false) 87 : valid(false)
89 , internalFormat(0) 88 , internalFormat(0)
90 , width(0) 89 , width(0)
91 , height(0) 90 , height(0)
92 , type(0) 91 , type(0)
93 { 92 {
94 } 93 }
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 bool m_isCubeComplete; 129 bool m_isCubeComplete;
131 bool m_isComplete; 130 bool m_isComplete;
132 bool m_needToUseBlackTexture; 131 bool m_needToUseBlackTexture;
133 bool m_isFloatType; 132 bool m_isFloatType;
134 bool m_isHalfFloatType; 133 bool m_isHalfFloatType;
135 }; 134 };
136 135
137 } // namespace blink 136 } // namespace blink
138 137
139 #endif // WebGLTexture_h 138 #endif // WebGLTexture_h
OLDNEW
« no previous file with comments | « Source/core/html/HTMLUnknownElement.h ('k') | Source/core/html/forms/RadioInputType.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698