Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 6997008: Fix QuotaFileUtil to write .usage into the same directory as "chrome-", not under "chrome-*". (Closed)

Created:
9 years, 7 months ago by Dai Mikurube (NOT FULLTIME)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, kinuko+watch, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix QuotaFileUtil to write .usage into the same directory as "chrome-", not under "chrome-*". BUG=74841 TEST=QuotaFileUtilTest.*

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Mofified tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -32 lines) Patch
M webkit/fileapi/quota_file_util.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/fileapi/quota_file_util_unittest.cc View 1 2 3 chunks +25 lines, -30 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Dai Mikurube (NOT FULLTIME)
Just a small fix.
9 years, 7 months ago (2011-05-10 08:07:45 UTC) #1
kinuko
lgtm
9 years, 7 months ago (2011-05-10 09:15:39 UTC) #2
Dai Mikurube (NOT FULLTIME)
Thanks. Checked "Commit".
9 years, 7 months ago (2011-05-10 09:19:21 UTC) #3
commit-bot: I haz the power
Can't apply patch for file webkit/fileapi/quota_file_util.cc. patching file webkit/fileapi/quota_file_util.cc Hunk #1 FAILED at 12. Hunk ...
9 years, 7 months ago (2011-05-10 09:19:27 UTC) #4
Dai Mikurube (NOT FULLTIME)
On 2011/05/10 09:19:27, commit-bot wrote: > Can't apply patch for file webkit/fileapi/quota_file_util.cc. > patching file ...
9 years, 7 months ago (2011-05-10 09:27:06 UTC) #5
commit-bot: I haz the power
Change committed as 84771
9 years, 7 months ago (2011-05-10 10:28:44 UTC) #6
Dai Mikurube (NOT FULLTIME)
This change (the patch set 2) broke the build because of failure in QuotaFileUtilTest. I ...
9 years, 7 months ago (2011-05-10 14:01:23 UTC) #7
Dai Mikurube (NOT FULLTIME)
FYI: The previous patch has already been reverted at http://codereview.chromium.org/6995017/ kindly by cbentzel.
9 years, 7 months ago (2011-05-10 14:06:34 UTC) #8
Dai Mikurube (NOT FULLTIME)
9 years, 7 months ago (2011-05-11 05:51:06 UTC) #9
Closing this change.

Powered by Google App Engine
This is Rietveld 408576698