Continue with InlineBox float->LayoutUnit migration.

Source/core/rendering/FloatToLayoutUnit.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef FloatToLayoutUnit_h
 #define FloatToLayoutUnit_h
 
 namespace blink {
 
 #if ENABLE(LAYOUT_UNIT_IN_INLINE_BOXES)
 
 class LayoutUnit;
 class LayoutPoint;
 class LayoutRect;
 class LayoutSize;
 
 using FloatWillBeLayoutUnit = LayoutUnit;
 using FloatPointWillBeLayoutPoint = LayoutPoint;
 using FloatRectWillBeLayoutRect = LayoutRect;
 using FloatSizeWillBeLayoutSize = LayoutSize;
 
 #define ZERO_LAYOUT_UNIT LayoutUnit(0)
 #define MINUS_ONE_LAYOUT_UNIT LayoutUnit(-1)
 
 #define LAYOUT_UNIT_TO_FLOAT(layoutUnit) (layoutUnit)
+#define WILL_BE_LAYOUT_UNIT_TO_FLOAT(layoutUnit) (layoutUnit.toFloat())

[leviw_travelin_and_unemployed, 2014/11/03 21:35:02]

These names don't actually seem self-identifying to me. LAYOUT_UNIT_TO_FLOAT and
WILL_BE_LAYOUT_UNIT_TO_FLOAT don't imply the actual difference.

It seems to me that you want a class to make this indirection not awful. With
the conversion to sub-pixel layout, we used LayoutUnit (originally an integer),
which you could optionally point at FractionalLayoutUnit (sub-pixel magic).

If you did that, it seems to me that you could have much more reasonable and
understandable conversions to other types. This model is hard to parse for me.

 #define LAYOUT_UNIT_CEIL(layoutUnit) (layoutUnit.ceil())
 #define INT_TO_LAYOUT_UNIT(i) (LayoutUnit(i))
+#define WILL_BE_LAYOUT_UNIT_TO_INT(layoutUnit) (layoutUnit.toInt())
+#define LAYOUT_UNIT_ROUND(layoutUnit) (layoutUnit.round())
 
 #else // ENABLE(LAYOUT_UNIT_IN_INLINE_BOXES)
 
 class FloatPoint;
 class FloatRect;
 class FloatSize;
 
 using FloatWillBeLayoutUnit = float;
 using FloatPointWillBeLayoutPoint = FloatPoint;
 using FloatRectWillBeLayoutRect = FloatRect;
 using FloatSizeWillBeLayoutSize = FloatSize;
 
 #define ZERO_LAYOUT_UNIT 0
 #define MINUS_ONE_LAYOUT_UNIT -1
 
 #define LAYOUT_UNIT_TO_FLOAT(layoutUnit) (layoutUnit.toFloat())
+#define WILL_BE_LAYOUT_UNIT_TO_FLOAT(layoutUnit) (layoutUnit)
 #define LAYOUT_UNIT_CEIL(layoutUnit) (ceilf(layoutUnit))
 #define INT_TO_LAYOUT_UNIT(i) (i)
+#define WILL_BE_LAYOUT_UNIT_TO_INT(layoutUnit) (layoutUnit)
+#define LAYOUT_UNIT_ROUND(layoutUnit) (lroundf(layoutUnit))
 
 #endif // ENABLE(LAYOUT_UNIT_IN_INLINE_BOXES)
 
 } // namespace blink
 
 #endif // FloatToLayoutUnit_h