src/core/SkDraw.cpp - Issue 699623003: Crop the fast path dashed lines to the cull rect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkDraw.cpp

Issue 699623003: Crop the fast path dashed lines to the cull rect (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Address coordinate xform issue Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkDraw.cpp

diff --git a/src/core/SkDraw.cpp b/src/core/SkDraw.cpp

index 82fd84b8bc740768681efeb7d6a3273f226568f5..b9c39fa8ceed6c0f44d7983bdbd34c149cc62eaa 100644

--- a/src/core/SkDraw.cpp

+++ b/src/core/SkDraw.cpp

@@ -460,7 +460,7 @@ bool PtProcRec::init(SkCanvas::PointMode mode, const SkPaint& paint,

return true;

}

if (paint.getStrokeCap() != SkPaint::kRound_Cap &&

- matrix->rectStaysRect() && SkCanvas::kPoints_PointMode == mode) {

+ matrix->isScaleTranslate() && SkCanvas::kPoints_PointMode == mode) {

SkScalar sx = matrix->get(SkMatrix::kMScaleX);

SkScalar sy = matrix->get(SkMatrix::kMScaleY);

if (SkScalarNearlyZero(sx - sy)) {

« no previous file with comments | « include/core/SkMatrix.h ('k') | src/effects/SkDashPathEffect.cpp » ('j') | no next file with comments »