Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 699613004: Revert "In-object double fields unboxing (for 64-bit only)." (Closed)

Created:
6 years, 1 month ago by Toon Verwaest
Modified:
6 years, 1 month ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Revert "In-object double fields unboxing (for 64-bit only)." Revert "Fixes for Windows and Mac builds after r25250." TBR=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25252

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -1854 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 5 chunks +5 lines, -11 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 2 chunks +25 lines, -28 lines 0 comments Download
M src/field-index.h View 3 chunks +2 lines, -4 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/globals.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/heap/heap.cc View 4 chunks +3 lines, -30 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +1 line, -12 lines 0 comments Download
M src/heap/objects-visiting.h View 6 chunks +13 lines, -58 lines 0 comments Download
M src/heap/objects-visiting.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M src/heap/store-buffer.cc View 1 chunk +5 lines, -27 lines 0 comments Download
M src/hydrogen.cc View 4 chunks +9 lines, -22 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/json-stringifier.h View 1 chunk +2 lines, -9 lines 0 comments Download
D src/layout-descriptor.h View 1 chunk +0 lines, -126 lines 0 comments Download
D src/layout-descriptor.cc View 1 chunk +0 lines, -146 lines 0 comments Download
D src/layout-descriptor-inl.h View 1 chunk +0 lines, -185 lines 0 comments Download
M src/objects.h View 10 chunks +15 lines, -47 lines 0 comments Download
M src/objects.cc View 32 chunks +102 lines, -204 lines 0 comments Download
M src/objects-debug.cc View 4 chunks +2 lines, -28 lines 0 comments Download
M src/objects-inl.h View 13 chunks +6 lines, -135 lines 0 comments Download
M src/objects-printer.cc View 4 chunks +2 lines, -49 lines 0 comments Download
M src/property-details.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/string-stream.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +2 lines, -11 lines 0 comments Download
D test/cctest/test-unboxed-doubles.cc View 1 chunk +0 lines, -668 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Toon Verwaest
6 years, 1 month ago (2014-11-10 17:44:24 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25252 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698