Change DtmfSenderHandler to handle events on the signaling thread.

Change DtmfSenderHandler to handle events on the signaling thread.
Since the RTCPeerConnectionHandler now uses a separate thread for API-calls to libjingle (https://codereview.chromium.org/675013005/) the DtmfSenderHandler must also handle events on the signaling thread.

This cl also fix a problem where a remote video source falsly DCHECKs that an event have been missed.

TEST=out/Debug/content_browsertests --gtest_filter=WebRtcBrowserTest.MANU* --run-manual
BUG=369796
Committed: https://crrev.com/57f60d90e573ff287f73ba7ac447d6ff333745a9
Cr-Commit-Position: refs/heads/master@{#302439}

[perkj_chrome, 2014-11-03 13:22:54]

perkj@chromium.org changed reviewers:
+ tommi@chromium.org

[perkj_chrome, 2014-11-03 13:22:55]

Please take a look.

[tommi (sloooow) - chröme, 2014-11-03 13:49:56]

https://codereview.chromium.org/699613002/diff/1/content/renderer/media/rtc_d...
File content/renderer/media/rtc_dtmf_sender_handler.cc (right):

https://codereview.chromium.org/699613002/diff/1/content/renderer/media/rtc_d...
content/renderer/media/rtc_dtmf_sender_handler.cc:45: const
scoped_refptr<base::MessageLoopProxy> main_thread_;
const scoped_refptr<base::SingleThreadTaskRunner> main_thread_; ?

https://codereview.chromium.org/699613002/diff/1/content/renderer/media/rtc_d...
content/renderer/media/rtc_dtmf_sender_handler.cc:54: observer_ = new
Observer(weak_factory_.GetWeakPtr());
nit: initializer list? (should be ok as long as it comes after weak_factory_

https://codereview.chromium.org/699613002/diff/1/content/renderer/media/webrt...
File content/renderer/media/webrtc/media_stream_remote_video_source.cc (right):

https://codereview.chromium.org/699613002/diff/1/content/renderer/media/webrt...
content/renderer/media/webrtc/media_stream_remote_video_source.cc:162:
DLOG(ERROR) << "SetSource";
remove? (and the rest of the debug logging)

https://codereview.chromium.org/699613002/diff/1/content/renderer/media/webrt...
File content/renderer/media/webrtc/media_stream_remote_video_source.h (right):

https://codereview.chromium.org/699613002/diff/1/content/renderer/media/webrt...
content/renderer/media/webrtc/media_stream_remote_video_source.h:48: bool
source_set_;
nit:
#if DCHECK_IS_ON
    bool source_set_;
#endif

[perkj_chrome, 2014-11-03 14:53:33]

PTAL

https://codereview.chromium.org/699613002/diff/1/content/renderer/media/rtc_d...
File content/renderer/media/rtc_dtmf_sender_handler.cc (right):

https://codereview.chromium.org/699613002/diff/1/content/renderer/media/rtc_d...
content/renderer/media/rtc_dtmf_sender_handler.cc:45: const
scoped_refptr<base::MessageLoopProxy> main_thread_;
On 2014/11/03 13:49:56, tommi wrote:
> const scoped_refptr<base::SingleThreadTaskRunner> main_thread_; ?

Done.

https://codereview.chromium.org/699613002/diff/1/content/renderer/media/rtc_d...
content/renderer/media/rtc_dtmf_sender_handler.cc:54: observer_ = new
Observer(weak_factory_.GetWeakPtr());
On 2014/11/03 13:49:56, tommi wrote:
> nit: initializer list? (should be ok as long as it comes after weak_factory_

Done.

https://codereview.chromium.org/699613002/diff/1/content/renderer/media/webrt...
File content/renderer/media/webrtc/media_stream_remote_video_source.cc (right):

https://codereview.chromium.org/699613002/diff/1/content/renderer/media/webrt...
content/renderer/media/webrtc/media_stream_remote_video_source.cc:162:
DLOG(ERROR) << "SetSource";
On 2014/11/03 13:49:56, tommi wrote:
> remove? (and the rest of the debug logging)

sorry....

[tommi (sloooow) - chröme, 2014-11-03 15:22:23]

The CQ bit was checked by tommi@chromium.org

[tommi (sloooow) - chröme, 2014-11-03 15:22:24]

lgtm

[commit-bot: I haz the power, 2014-11-03 15:23:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/699613002/20001

[commit-bot: I haz the power, 2014-11-03 15:58:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-03 15:58:59]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[perkj_chrome, 2014-11-03 16:05:20]

The CQ bit was checked by perkj@chromium.org

[commit-bot: I haz the power, 2014-11-03 16:06:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/699613002/40001

[commit-bot: I haz the power, 2014-11-03 16:57:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-03 16:58:08]

Patchset 3 (id:??) landed as
https://crrev.com/57f60d90e573ff287f73ba7ac447d6ff333745a9
Cr-Commit-Position: refs/heads/master@{#302439}

[dmichael (off chromium), 2014-12-04 19:28:46]

dmichael@chromium.org changed reviewers:
+ dmichael@chromium.org

[dmichael (off chromium), 2014-12-04 19:28:47]

https://codereview.chromium.org/699613002/diff/1/content/renderer/media/rtc_d...
File content/renderer/media/rtc_dtmf_sender_handler.cc (right):

https://codereview.chromium.org/699613002/diff/1/content/renderer/media/rtc_d...
content/renderer/media/rtc_dtmf_sender_handler.cc:54: observer_ = new
Observer(weak_factory_.GetWeakPtr());
WeakPtrFactory should always be the last member...  see
crbug.com/303818
I'm working on some CLs to fix this up, but I wanted to let you guys know. You
can read the bug and/or comments in weak_ptr.h for an explanation.