Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 699593003: Replace fast/multicol/float-paginate-complex with float-big-line. (Closed)

Created:
6 years, 1 month ago by andersr
Modified:
6 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace fast/multicol/float-paginate-complex with float-big-line. The test float-paginate-complex adds nothing over the other float-* tests, except the case with a big line box. That case has been split out into a new reftest: float-big-line. R=mstensho@opera.com BUG=386567 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184876

Patch Set 1 #

Patch Set 2 : Reupload with --no-find-copies. #

Total comments: 4

Patch Set 3 : Set line-height, add pass description. #

Total comments: 2

Patch Set 4 : Set explicit line-height. (Approx. font-size*1.2). #

Patch Set 5 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -3712 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 3 chunks +0 lines, -4 lines 0 comments Download
A LayoutTests/fast/multicol/float-big-line.html View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/float-big-line-expected.html View 1 2 3 1 chunk +52 lines, -0 lines 0 comments Download
D LayoutTests/fast/multicol/float-paginate-complex.html View 1 chunk +0 lines, -50 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/float-paginate-complex.html View 1 2 1 chunk +0 lines, -49 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/float-paginate-complex-expected.html View 1 2 1 chunk +0 lines, -49 lines 0 comments Download
A LayoutTests/fast/multicol/vertical-lr/float-big-line.html View 1 2 3 1 chunk +51 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/vertical-lr/float-big-line-expected.html View 1 2 3 1 chunk +54 lines, -0 lines 0 comments Download
D LayoutTests/fast/multicol/vertical-lr/float-paginate-complex.html View 1 chunk +0 lines, -49 lines 0 comments Download
A LayoutTests/fast/multicol/vertical-rl/float-big-line.html View 1 2 3 1 chunk +51 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/vertical-rl/float-big-line-expected.html View 1 2 3 1 chunk +54 lines, -0 lines 0 comments Download
D LayoutTests/fast/multicol/vertical-rl/float-paginate-complex.html View 1 chunk +0 lines, -49 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/float-paginate-complex-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/float-paginate-complex-expected.txt View 1 chunk +0 lines, -302 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/vertical-lr/float-paginate-complex-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/vertical-lr/float-paginate-complex-expected.txt View 1 chunk +0 lines, -302 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/vertical-rl/float-paginate-complex-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/vertical-rl/float-paginate-complex-expected.txt View 1 chunk +0 lines, -258 lines 0 comments Download
D LayoutTests/platform/mac/fast/multicol/float-paginate-complex-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/float-paginate-complex-expected.txt View 1 chunk +0 lines, -307 lines 0 comments Download
D LayoutTests/platform/mac/fast/multicol/vertical-lr/float-paginate-complex-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/vertical-lr/float-paginate-complex-expected.txt View 1 chunk +0 lines, -306 lines 0 comments Download
D LayoutTests/platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.txt View 1 chunk +0 lines, -258 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/float-paginate-complex-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/float-paginate-complex-expected.txt View 1 chunk +0 lines, -302 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/vertical-lr/float-paginate-complex-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/vertical-lr/float-paginate-complex-expected.txt View 1 chunk +0 lines, -302 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/vertical-rl/float-paginate-complex-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/vertical-rl/float-paginate-complex-expected.txt View 1 chunk +0 lines, -258 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/float-paginate-complex-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/float-paginate-complex-expected.txt View 1 chunk +0 lines, -305 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/vertical-lr/float-paginate-complex-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/vertical-lr/float-paginate-complex-expected.txt View 1 chunk +0 lines, -304 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/vertical-rl/float-paginate-complex-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/vertical-rl/float-paginate-complex-expected.txt View 1 chunk +0 lines, -258 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
andersr
6 years, 1 month ago (2014-11-03 13:30:52 UTC) #1
mstensho (USE GERRIT)
https://codereview.chromium.org/699593003/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (left): https://codereview.chromium.org/699593003/diff/20001/LayoutTests/TestExpectations#oldcode1046 LayoutTests/TestExpectations:1046: crbug.com/350853 fast/multicol/newmulticol/float-paginate-complex.html [ Skip ] This newmulticol/ test should ...
6 years, 1 month ago (2014-11-03 13:45:45 UTC) #2
andersr
https://codereview.chromium.org/699593003/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (left): https://codereview.chromium.org/699593003/diff/20001/LayoutTests/TestExpectations#oldcode1046 LayoutTests/TestExpectations:1046: crbug.com/350853 fast/multicol/newmulticol/float-paginate-complex.html [ Skip ] On 2014/11/03 13:45:45, mstensho ...
6 years, 1 month ago (2014-11-04 11:24:24 UTC) #3
mstensho (USE GERRIT)
lgtm with one nit (which applies to all three tests). https://codereview.chromium.org/699593003/diff/40001/LayoutTests/fast/multicol/float-big-line.html File LayoutTests/fast/multicol/float-big-line.html (right): https://codereview.chromium.org/699593003/diff/40001/LayoutTests/fast/multicol/float-big-line.html#newcode13 ...
6 years, 1 month ago (2014-11-04 21:29:42 UTC) #4
andersr
https://codereview.chromium.org/699593003/diff/40001/LayoutTests/fast/multicol/float-big-line.html File LayoutTests/fast/multicol/float-big-line.html (right): https://codereview.chromium.org/699593003/diff/40001/LayoutTests/fast/multicol/float-big-line.html#newcode13 LayoutTests/fast/multicol/float-big-line.html:13: line-height: initial; On 2014/11/04 21:29:42, mstensho wrote: > Some ...
6 years, 1 month ago (2014-11-05 15:01:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699593003/60001
6 years, 1 month ago (2014-11-05 15:02:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/15921) linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/31796) linux_blink_rel ...
6 years, 1 month ago (2014-11-05 15:06:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699593003/100001
6 years, 1 month ago (2014-11-05 15:26:50 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 16:32:44 UTC) #13
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as 184876

Powered by Google App Engine
This is Rietveld 408576698