Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 699573002: [turbofan] Positive dividends are heavily favored for Int32Mod. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Positive dividends are heavily favored for Int32Mod. Mark negative dividend case as deferred, as modulus by power of two with negative dividend almost never appears in practice. R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25065

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/compiler/machine-operator-reducer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 1 month ago (2014-11-03 10:43:20 UTC) #1
dcarney
lgtm
6 years, 1 month ago (2014-11-03 10:44:06 UTC) #2
Benedikt Meurer
6 years, 1 month ago (2014-11-03 10:44:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25065 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698