Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1758)

Unified Diff: content/browser/renderer_host/media/audio_renderer_host.cc

Issue 69953026: Log actual streams, not output controllers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Mac. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/browser_main_loop.cc ('k') | media/audio/audio_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/media/audio_renderer_host.cc
diff --git a/content/browser/renderer_host/media/audio_renderer_host.cc b/content/browser/renderer_host/media/audio_renderer_host.cc
index 7e6ab82fef96cc4de9dddad7a99e16c3a704f831..d7e5204e7ada2938f7113f18e94769abba12d2bc 100644
--- a/content/browser/renderer_host/media/audio_renderer_host.cc
+++ b/content/browser/renderer_host/media/audio_renderer_host.cc
@@ -379,10 +379,10 @@ void AudioRendererHost::OnCreateStream(
render_process_id_, entry->render_view_id(), entry->controller());
}
audio_entries_.insert(std::make_pair(stream_id, entry.release()));
- if (media_internals_) {
- media_internals_->OnAudioStreamCreated(
- this, stream_id, params, input_device_id);
- }
+ // if (media_internals_) {
+ // media_internals_->OnAudioStreamCreated(
+ // this, stream_id, params, input_device_id);
+ // }
}
void AudioRendererHost::OnPlayStream(int stream_id) {
@@ -395,8 +395,8 @@ void AudioRendererHost::OnPlayStream(int stream_id) {
}
entry->controller()->Play();
- if (media_internals_)
- media_internals_->OnSetAudioStreamPlaying(this, stream_id, true);
+ // if (media_internals_)
+ // media_internals_->OnSetAudioStreamPlaying(this, stream_id, true);
}
void AudioRendererHost::OnPauseStream(int stream_id) {
@@ -409,8 +409,8 @@ void AudioRendererHost::OnPauseStream(int stream_id) {
}
entry->controller()->Pause();
- if (media_internals_)
- media_internals_->OnSetAudioStreamPlaying(this, stream_id, false);
+ // if (media_internals_)
+ // media_internals_->OnSetAudioStreamPlaying(this, stream_id, false);
}
void AudioRendererHost::OnSetVolume(int stream_id, double volume) {
@@ -426,8 +426,8 @@ void AudioRendererHost::OnSetVolume(int stream_id, double volume) {
if (volume < 0 || volume > 1.0)
return;
entry->controller()->SetVolume(volume);
- if (media_internals_)
- media_internals_->OnSetAudioStreamVolume(this, stream_id, volume);
+ // if (media_internals_)
+ // media_internals_->OnSetAudioStreamVolume(this, stream_id, volume);
}
void AudioRendererHost::SendErrorMessage(int stream_id) {
@@ -454,8 +454,8 @@ void AudioRendererHost::OnCloseStream(int stream_id) {
controller->Close(
base::Bind(&AudioRendererHost::DeleteEntry, this, base::Passed(&entry)));
- if (media_internals_)
- media_internals_->OnSetAudioStreamStatus(this, stream_id, "closed");
+ // if (media_internals_)
+ // media_internals_->OnSetAudioStreamStatus(this, stream_id, "closed");
}
void AudioRendererHost::DeleteEntry(scoped_ptr<AudioEntry> entry) {
@@ -471,8 +471,8 @@ void AudioRendererHost::DeleteEntry(scoped_ptr<AudioEntry> entry) {
}
// Notify the media observer.
- if (media_internals_)
- media_internals_->OnDeleteAudioStream(this, entry->stream_id());
+ // if (media_internals_)
+ // media_internals_->OnDeleteAudioStream(this, entry->stream_id());
// Note: |entry| will be deleted upon leaving this scope.
}
@@ -488,8 +488,8 @@ void AudioRendererHost::ReportErrorAndClose(int stream_id) {
SendErrorMessage(stream_id);
- if (media_internals_)
- media_internals_->OnSetAudioStreamStatus(this, stream_id, "error");
+ // if (media_internals_)
+ // media_internals_->OnSetAudioStreamStatus(this, stream_id, "error");
OnCloseStream(stream_id);
}
« no previous file with comments | « content/browser/browser_main_loop.cc ('k') | media/audio/audio_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698