Issue 69953025: Support use_glib==0 on Linux in base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 69953025: Support use_glib==0 on Linux in base (Closed)

Created:
7 years, 1 month ago by spang

Modified:
7 years, 1 month ago

Reviewers:
brettw

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Support use_glib==0 on Linux in base This makes base build on Linux when use_glib is set to 0. The only glib bits we are currently using in that configuration are g_get_home_dir() and g_try_malloc(). Use of g_get_home_dir() is not essential. Without glib, we can just rely on the $HOME environment variable always. Use of g_try_malloc() is just a way to cause a large memory allocation from a shared library. We can achieve the same effect using asprintf(). BUG=318315, 318413, 170408 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236162

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -10 lines)			Patch
M	base/file_util_posix.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	base/process/memory_unittest.cc	View	1 2	3 chunks	+6 lines, -7 lines	0 comments	Download
M	base/process/process_util_unittest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	build/common.gypi	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download