Issue 69953007: Move CustomFontData to platform/fonts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 69953007: Move CustomFontData to platform/fonts. (Closed)

Created:
7 years, 1 month ago by dglazkov

Modified:
7 years, 1 month ago

Reviewers:
Stephen Chennney, eae

CC:
blink-reviews, jamesr, krit, dsinclair, danakj, dglazkov+blink, Rik, apavlov+blink_chromium.org, darktears, pdr, f(malita), Stephen Chennney, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move CustomFontData to platform/fonts. R=schenney@chromium.org,eae BUG=303332

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -77 lines)			Patch
M	Source/core/core.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/css/CSSCustomFontData.h	View	1 chunk	+1 line, -1 line	0 comments	Download
D	Source/core/platform/graphics/CustomFontData.h	View	1 chunk	+0 lines, -72 lines	0 comments	Download
M	Source/core/platform/graphics/SimpleFontData.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGFontData.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/blink_platform.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	Source/platform/fonts/CustomFontData.h	View	1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eae

https://codereview.chromium.org/69953007/diff/1/Source/platform/fonts/CustomFontData.h File Source/platform/fonts/CustomFontData.h (right): https://codereview.chromium.org/69953007/diff/1/Source/platform/fonts/CustomFontData.h#newcode35 Source/platform/fonts/CustomFontData.h:35: struct WidthIterator; You'll need to use Source/core/css/CSSFontFaceSource.h and Source/core/platform/graphics/WidthIterator.h ...

7 years, 1 month ago (2013-11-12 23:18:32 UTC) #2

eae explained offline, closing.

Expand Messages | Collapse Messages