Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: components/plugins/renderer/mobile_youtube_plugin.h

Issue 69953006: Bind plugin placeholder directly to v8 instead of over CppBoundClass (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/plugins/renderer/DEPS ('k') | components/plugins/renderer/mobile_youtube_plugin.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/plugins/renderer/mobile_youtube_plugin.h
diff --git a/components/plugins/renderer/mobile_youtube_plugin.h b/components/plugins/renderer/mobile_youtube_plugin.h
index 80a4f99ca9b8d896a8c01f994fe22b8466eee665..a6b86745b6f3a0886db61f5f1c6b7178f6c732aa 100644
--- a/components/plugins/renderer/mobile_youtube_plugin.h
+++ b/components/plugins/renderer/mobile_youtube_plugin.h
@@ -26,12 +26,12 @@ class MobileYouTubePlugin : public PluginPlaceholder {
static bool IsYouTubeURL(const GURL& url, const std::string& mime_type);
private:
+ virtual ~MobileYouTubePlugin();
+
// Opens a youtube app in the current tab.
- void OpenYoutubeUrlCallback(const webkit_glue::CppArgumentList& args,
- webkit_glue::CppVariant* result);
+ void OpenYoutubeUrlCallback();
- // WebViewPlugin::Delegate (via PluginPlaceholder) method
- virtual void BindWebFrame(blink::WebFrame* frame) OVERRIDE;
+ base::WeakPtrFactory<MobileYouTubePlugin> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(MobileYouTubePlugin);
};
« no previous file with comments | « components/plugins/renderer/DEPS ('k') | components/plugins/renderer/mobile_youtube_plugin.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698