Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: chrome/renderer/plugins/chrome_plugin_placeholder.h

Issue 69953006: Bind plugin placeholder directly to v8 instead of over CppBoundClass (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/plugins/chrome_plugin_placeholder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/plugins/chrome_plugin_placeholder.h
diff --git a/chrome/renderer/plugins/chrome_plugin_placeholder.h b/chrome/renderer/plugins/chrome_plugin_placeholder.h
index 0e8b1e38768aba3f0cb0c84d8e796a3ff07eb967..64f64507f493742635e449fe8d5cb9a726b6c2da 100644
--- a/chrome/renderer/plugins/chrome_plugin_placeholder.h
+++ b/chrome/renderer/plugins/chrome_plugin_placeholder.h
@@ -49,9 +49,6 @@ class ChromePluginPlaceholder : public plugins::PluginPlaceholder,
const string16& title);
virtual ~ChromePluginPlaceholder();
- // WebViewPlugin::Delegate (via PluginPlaceholder) method
- virtual void BindWebFrame(blink::WebFrame* frame) OVERRIDE;
-
// content::RenderViewObserver (via PluginPlaceholder) override:
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
@@ -66,9 +63,7 @@ class ChromePluginPlaceholder : public plugins::PluginPlaceholder,
virtual void OnMenuClosed(int request_id) OVERRIDE;
// Javascript callback opens chrome://plugins in a new tab.
- // Arguments are required by the caller, but not used.
- void OpenAboutPluginsCallback(const webkit_glue::CppArgumentList& args,
- webkit_glue::CppVariant* result);
+ void OpenAboutPluginsCallback();
void OnLoadBlockedPlugins(const std::string& identifier);
void OnSetIsPrerendering(bool is_prerendering);
@@ -97,6 +92,8 @@ class ChromePluginPlaceholder : public plugins::PluginPlaceholder,
int context_menu_request_id_; // Nonzero when request pending.
string16 plugin_name_;
+ base::WeakPtrFactory<ChromePluginPlaceholder> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(ChromePluginPlaceholder);
};
« no previous file with comments | « no previous file | chrome/renderer/plugins/chrome_plugin_placeholder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698