Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: components/plugins/renderer/mobile_youtube_plugin.h

Issue 69953006: Bind plugin placeholder directly to v8 instead of over CppBoundClass (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/plugins/renderer/mobile_youtube_plugin.h
diff --git a/components/plugins/renderer/mobile_youtube_plugin.h b/components/plugins/renderer/mobile_youtube_plugin.h
index 80a4f99ca9b8d896a8c01f994fe22b8466eee665..5af508371f8a5a13cf278085070a43ffd8ba7c94 100644
--- a/components/plugins/renderer/mobile_youtube_plugin.h
+++ b/components/plugins/renderer/mobile_youtube_plugin.h
@@ -27,11 +27,12 @@ class MobileYouTubePlugin : public PluginPlaceholder {
private:
// Opens a youtube app in the current tab.
- void OpenYoutubeUrlCallback(const webkit_glue::CppArgumentList& args,
- webkit_glue::CppVariant* result);
+ static void OpenYoutubeUrlCallback(
+ const v8::FunctionCallbackInfo<v8::Value>& args);
- // WebViewPlugin::Delegate (via PluginPlaceholder) method
- virtual void BindWebFrame(blink::WebFrame* frame) OVERRIDE;
+ // PluginPlaceholder method
+ virtual void InstallAdditionalCallbacks(
+ v8::Handle<v8::Template> prototype) OVERRIDE;
DISALLOW_COPY_AND_ASSIGN(MobileYouTubePlugin);
};

Powered by Google App Engine
This is Rietveld 408576698