Issue 699493004: Fix push script for autoroll account.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 699493004: Fix push script for autoroll account. (Closed)

Created:
6 years, 1 month ago by Michael Achenbach

Modified:
6 years, 1 month ago

Reviewers:
tandrii(chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix push script for autoroll account. Push tags to the repo not to the remote - which is a cache checkout on the bots. Add new files when doing pure svn commits. Otherwise, new files are silently ignored and not committed. BUG=408523 LOG=n TEST=script_test.py TBR=tandrii@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25049

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -2 lines)			Patch
	M	tools/push-to-trunk/common_includes.py	View		4 chunks	+12 lines, -1 line	1 comment	Download
	M	tools/push-to-trunk/test_scripts.py	View		3 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Michael Achenbach

PTAL https://codereview.chromium.org/699493004/diff/1/tools/push-to-trunk/common_includes.py File tools/push-to-trunk/common_includes.py (right): https://codereview.chromium.org/699493004/diff/1/tools/push-to-trunk/common_includes.py#newcode734 tools/push-to-trunk/common_includes.py:734: if not self.Command("patch", "-d %s -p1 -i %s" ...

6 years, 1 month ago (2014-11-02 12:47:03 UTC) #2

Michael Achenbach

Committed patchset #1 (id:1) manually as 25049 (presubmit successful).

6 years, 1 month ago (2014-11-02 13:12:57 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages