Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 699473002: 429168: fix for PdfJs regression (Closed)

Created:
6 years, 1 month ago by mvstanton
Modified:
6 years, 1 month ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix for bug 429168, PdfJs regression. We pay a very high cost for AllocationResult being a > kPointerSize struct. This can be avoided by using Smis to indicate failure with retry spaces. BUG=429168 LOG=N R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25057

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M src/globals.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/spaces.h View 2 chunks +12 lines, -7 lines 0 comments Download
M src/serialize.h View 1 chunk +1 line, -1 line 0 comments Download
M src/serialize.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-alloc.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mvstanton
Hi Yang, I carried out your idea of using Smi to encode failure with a ...
6 years, 1 month ago (2014-11-01 15:34:24 UTC) #2
Yang
On 2014/11/01 15:34:24, mvstanton wrote: > Hi Yang, > I carried out your idea of ...
6 years, 1 month ago (2014-11-03 08:04:52 UTC) #3
mvstanton
6 years, 1 month ago (2014-11-03 08:43:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25057 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698