Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 699453002: win/clang: Fix a warning by removing superflous braces. (Closed)

Created:
6 years, 1 month ago by Nico
Modified:
6 years, 1 month ago
Reviewers:
perkj_chrome, mcasas
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

win/clang: Fix a warning by removing superflous braces. Also make a global more const. BUG=82385 Committed: https://crrev.com/ed76c99e380d6d49a3b2231b1ac7a393e9b15d95 Cr-Commit-Position: refs/heads/master@{#302432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M media/video/capture/win/video_capture_device_factory_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Nico
6 years, 1 month ago (2014-11-01 04:38:15 UTC) #2
mcasas
LGTM - apologies for the delay, thanks!
6 years, 1 month ago (2014-11-03 08:42:29 UTC) #3
perkj_chrome
lgtm
6 years, 1 month ago (2014-11-03 09:17:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699453002/1
6 years, 1 month ago (2014-11-03 15:14:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-03 15:58:42 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 15:59:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed76c99e380d6d49a3b2231b1ac7a393e9b15d95
Cr-Commit-Position: refs/heads/master@{#302432}

Powered by Google App Engine
This is Rietveld 408576698