Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2640)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java

Issue 699333003: Support InputMethodManager#updateCursorAnchorInfo for Android 5.0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase before splitting this CL. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java b/content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java
index 12b2fdddcf70efcb01d7b85a746dc1a0cd44ca3a..9a1a40124cb89f07c31df023ccf5b29dc0e153a9 100644
--- a/content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java
+++ b/content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java
@@ -4,6 +4,8 @@
package org.chromium.content.browser;
+import org.chromium.base.VisibleForTesting;
+
/**
* Cached copy of all positions and scales (CSS-to-DIP-to-physical pixels)
* reported from the renderer.
@@ -70,6 +72,27 @@ public class RenderCoordinates {
}
/**
+ * Sets several fields for unit test. (used by {@link CursorAnchorInfoSourceTest}).
+ * @param deviceScaleFactor Device scale factor (maps DIP pixels to physical pixels).
+ * @param pageScaleFactor Page scale factor (maps CSS pixels to DIP pixels).
+ * @param scrollXCss Horizontal scroll offset in CSS pixels.
+ * @param scrollYCss Vertical scroll offset in CSS pixels.
+ * @param contentOffsetYPix Physical on-screen Y offset amount below the top controls.
+ */
+ @VisibleForTesting
+ public void setFrameInfoForTest(
+ float deviceScaleFactor, float pageScaleFactor,
+ float scrollXCss, float scrollYCss,
+ float contentOffsetYPix) {
+ reset();
+ mDeviceScaleFactor = deviceScaleFactor;
+ mPageScaleFactor = pageScaleFactor;
+ mScrollXCss = scrollXCss;
+ mScrollYCss = scrollYCss;
+ mContentOffsetYPix = contentOffsetYPix;
+ }
+
+ /**
* Handles conversion of a point from window-relative-local-dip or screen-pix
* to document-absolute-CSS space and vice versa.
*/

Powered by Google App Engine
This is Rietveld 408576698