content/browser/renderer_host/render_widget_host_view_android.cc - Issue 699333003: Support InputMethodManager#updateCursorAnchorInfo for Android 5.0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 699333003: Support InputMethodManager#updateCursorAnchorInfo for Android 5.0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase before splitting this CL. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc

index d7248af0bc9950a438ac7a079b90c21c87b6d4f7..abacbdaf6b40110c5fc73ab5b57a9bec8719e670 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.cc

+++ b/content/browser/renderer_host/render_widget_host_view_android.cc

@@ -871,7 +871,7 @@ void RenderWidgetHostViewAndroid::ImeCancelComposition() {

void RenderWidgetHostViewAndroid::ImeCompositionRangeChanged(

const gfx::Range& range,

const std::vector<gfx::Rect>& character_bounds) {

- // TODO(yukawa): Implement this.

+ ime_adapter_android_.SetCharacterBounds(character_bounds);

}

void RenderWidgetHostViewAndroid::FocusedNodeChanged(bool is_editable_node) {

@@ -1439,7 +1439,8 @@ void RenderWidgetHostViewAndroid::OnFrameMetadataUpdated(

frame_metadata.scrollable_viewport_size,

frame_metadata.location_bar_offset,

frame_metadata.location_bar_content_translation,

- is_mobile_optimized);

+ is_mobile_optimized,

+ frame_metadata.selection_start);

#if defined(VIDEO_HOLE)

if (host_ && host_->IsRenderView()) {

RenderViewHostImpl* rvhi = static_cast<RenderViewHostImpl*>(