Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java

Issue 699333003: Support InputMethodManager#updateCursorAnchorInfo for Android 5.0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move the core logic into Java side Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java b/content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java
index 108f5ec8ac6dfb50eb625fe04ba8b80a83513d57..9ee86874909545beefe1342b4c28fc4eceb99c5b 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/InputMethodManagerWrapper.java
@@ -4,7 +4,6 @@
package org.chromium.content.browser.input;
-import android.annotation.TargetApi;
import android.content.Context;
import android.os.Build;
import android.os.IBinder;
@@ -69,10 +68,17 @@ public class InputMethodManagerWrapper {
* @see android.view.inputmethod.InputMethodManager#updateCursorAnchorInfo(View,
* CursorAnchorInfo)
*/
- @TargetApi(Build.VERSION_CODES.LOLLIPOP)
- public void updateCursorAnchorInfo(View view, CursorAnchorInfo cursorAnchorInfo) {
- if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
- getInputMethodManager().updateCursorAnchorInfo(view, cursorAnchorInfo);
+ public void updateCursorAnchorInfo(View view, CursorAnchorInfoWrapper cursorAnchorInfo) {
+ if (Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP) {
jdduke (slow) 2015/02/09 17:01:17 Nit: No need for braces on these one liner early r
yukawa 2015/02/10 17:24:54 Done.
+ return;
}
+ if (cursorAnchorInfo == null) {
+ return;
+ }
+ Object realObject = cursorAnchorInfo.getObject();
+ if (!(realObject instanceof CursorAnchorInfo)) {
+ return;
+ }
+ getInputMethodManager().updateCursorAnchorInfo(view, (CursorAnchorInfo) realObject);
}
}

Powered by Google App Engine
This is Rietveld 408576698